Accessible Name for URL Input #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @bergatron |
|
Good catch @dctalbot! |
javan
reviewed
Aug 14, 2018
src/trix/config/toolbar.coffee
Outdated
| @@ -29,7 +29,7 @@ Trix.config.toolbar = | |||
| <div class="trix-dialogs" data-trix-dialogs> | |||
| <div class="trix-dialog trix-dialog--link" data-trix-dialog="href" data-trix-dialog-attribute="href"> | |||
| <div class="trix-dialog__link-fields"> | |||
| <input type="url" name="href" class="trix-input trix-input--dialog" placeholder="#{lang.urlPlaceholder}" required data-trix-input> | |||
| <input type="url" name="href" class="trix-input trix-input--dialog" placeholder="#{lang.urlPlaceholder}" aria-label="#{lang.urlAccessibility}" required data-trix-input> | |||
There was a problem hiding this comment.
I think the aria-label should just be "URL". You wouldn't use "Enter a URL" or "Enter a name" as a visible <label>s for form inputs.
There was a problem hiding this comment.
I agree. I pushed a commit to reflect this change.
javan
reviewed
Aug 15, 2018
src/trix/config/lang.coffee
Outdated
| @@ -17,6 +17,7 @@ Trix.config.lang = | |||
| strike: "Strikethrough" | |||
| undo: "Undo" | |||
| unlink: "Unlink" | |||
| urlAccessibility: "URL" | |||
There was a problem hiding this comment.
Let's drop Accessibility from this key. Just url is fine.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this on a code sniffer.
This url input element does not have a name available to an accessibility API.
Valid names are:
If you would like this to go forward, please let me know which attribute you would like to use and its value.
Reference:
Success Criterion