Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessible Name for URL Input #527

Merged
merged 8 commits into from
Aug 15, 2018
Merged

Accessible Name for URL Input #527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8a1647f
Replace broken Promises link
dctalbot Feb 24, 2018
8b635c8
Revert "Replace broken Promises link"
dctalbot Feb 26, 2018
f0d9202
Replace only the broken promises link
dctalbot Feb 26, 2018
542417b
resolve merge conflicts
dctalbot Aug 12, 2018
b979d19
add aria-label to link url input
dctalbot Aug 12, 2018
9eb8608
change URL aria-label
dctalbot Aug 14, 2018
60d4382
Rename URL language key
dctalbot Aug 15, 2018
4552a1a
Rename URL language key
dctalbot Aug 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/trix/config/lang.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ Trix.config.lang =
strike: "Strikethrough"
undo: "Undo"
unlink: "Unlink"
url: "URL"
urlPlaceholder: "Enter a URL…"
GB: "GB"
KB: "KB"
Expand Down
2 changes: 1 addition & 1 deletion src/trix/config/toolbar.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Trix.config.toolbar =
<div class="trix-dialogs" data-trix-dialogs>
<div class="trix-dialog trix-dialog--link" data-trix-dialog="href" data-trix-dialog-attribute="href">
<div class="trix-dialog__link-fields">
<input type="url" name="href" class="trix-input trix-input--dialog" placeholder="#{lang.urlPlaceholder}" required data-trix-input>
<input type="url" name="href" class="trix-input trix-input--dialog" placeholder="#{lang.urlPlaceholder}" aria-label="#{lang.url}" required data-trix-input>
<div class="trix-button-group">
<input type="button" class="trix-button trix-button--dialog" value="#{lang.link}" data-trix-method="setAttribute">
<input type="button" class="trix-button trix-button--dialog" value="#{lang.unlink}" data-trix-method="removeAttribute">
Expand Down