-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ku range fix #17
Ku range fix #17
Conversation
Conflicts: .travis.yml
RFC 2616 14.35.1 Byte Ranges If the last-byte-pos value is absent, or if the value is greater than or equal to the current length of the entity-body, last-byte-pos is taken to be equal to one less than the current length of the entity- body in bytes. Conflicts: src/mochiweb_http.erl
Was there any conflict in cherry-pick? [1] mochi/mochiweb@fe5e0c5?w=1 |
Ah, you did right. |
@@ -273,6 +271,8 @@ range_skip_length_test() -> | |||
%% invalid ranges | |||
?assertEqual(invalid_range, | |||
range_skip_length({-1, 30}, BodySize)), | |||
?assertEqual({0, BodySize}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test cases around this are all for invalid_rage
as an comment at line 271 (new) says.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are already cases for Size < End
around line 258, this case should move to there.
The test case to catch the bug when
|
Okay, here's updated unitests. |
Code looks nice, eunit test pass. |
This fix works well. |
Tagged v2.9.0p1 for this fix. |
This is cherry-pick of #7, for basho/riak_cs#1047. Needs tagging and webmachine update followed.