-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependent modules #1047
Update dependent modules #1047
Conversation
kuenishi
commented
Jan 14, 2015
- Update node_package, getopt, folsom, cluster_info to the latest
- Update riak-erlang-client and riak_repl_pb_api to 2.0.1/2.0.0
- lager 2.1.0 conflicts with lager_syslog 2.0.3 => not using
- riak_cs_multibag will be pinned with rebar_lock_deps_plugin
- Webmachine will be updated to upcoming 1.10.7
- update webmachine (https://github.com/basho/webmachine/pull/233) for Ku range fix mochiweb#17
- Update node_package, getopt, folsom, cluster_info to the latest - Update riak-erlang-client and riak_repl_pb_api to 2.0.1/2.0.0 - erlcloud and webmachine requires conflict resolution on ibrowse - lager 2.1.0 conflicts with lager_syslog 2.0.3 - riak_cs_multibag will be pinned with rebar_lock_deps_plugin
Fmm. Still having errors like
Looks like hard part of riak_pb is related. |
IIRC, the plugin uses hardcoded locked config file. This repository uses an environment variable to build two flavors (oss and enterprise). I'm wondering how these work well together 💭 |
Just for a memo: one issue I know now about webmachine/mochiweb upgrading. The changes in webmachine and forked mochiweb were [1] and [2]. [1] basho/mochiweb#7 |
I decided to ignore those three errors because they all come from riak_pb types and don't want to dive deep there. As Shino mentioned, |
basho/webmachine#124 is included in the latest webmachine develop (which is to be tagged as 1.10.7). basho/mochiweb#7 is waiting for merge as basho/mochiweb#17 . |
ed110eb
to
e0bdb9f
Compare
|
I think we should merge basho/riak_cs_multibag#16 first. |
@shino fmmm. It worked for me with the latest multibag. |
And https://github.com/basho/webmachine/pull/233 followed by 1.10.7 tag will be the last dependent work. |
Will run r_t on Monday. riak_cs_multibag will be tagged just before packaging/performance testing/release. |
@shino I reproduced! My rt configuration was bad; |
Fixed |
@@ -270,6 +271,9 @@ do_get_block(ReplyPid, Bucket, Key, ClusterID, UseProxyGet, ProxyActive, | |||
Timeout, ProceedFun, RetryFun, NumRetries, UseProxyGet, | |||
ProxyActive, ClusterID). | |||
|
|||
-spec try_local_get(riak_client(), binary(), binary(), list(), list(), | |||
timeout(), fun(), fun(), non_neg_integer(), boolean(), | |||
boolean(), binary()) -> no_return(). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The doc[1] says no_return()
= none()
is bottom type. But this function can return ok
or any term that ProceedFun
returns. It should be any()
or term()
.
[1] http://www.erlang.org/doc/reference_manual/typespec.html
- as well as change verbosity of boto_test - update boto to latest
59bb3a7
to
d5faf3d
Compare
Fixed the spec and force-pushed 😈 |
Update dependent modules Reviewed-by: shino
@borshop merge |