Add node_confirms option to PUT request
#371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add a long timeout to the datatype tests as they failed once or twice on timeout (I suspect it might have been a network issue acquiring an EQC license, but having a timeout hurts no one.)
As part of setting up for the 2.2.5 release I made a temp branch off the last released tag, this takes that branch back into the branch the tag was cut from.
Move deps back to dev-2.2
And counter/datatype operations. NOTE: depends on riak-2.2.5 `node_confirms` feature.
|
Travis fails because it doesn't know to use the riak_pb branch that this pull request builds on, is there anyway around that? Change the |
|
Am I correct in understanding the fail is due to the referenced p/r (riak_kv/riak_pb) not having been merged yet ? |
|
right, but I wonder if we can just tell travis to use the right branch somehow? |
|
The only think I could think of would be to send up a .gitconfig with the aproprate aliases in place but that's probably more effort than it's worth. When we get on rebar3, profiles could also be an option; but again, a lot of effort. I'll try to get the two dependent p/r reviewed today. |
|
merged pb and tada, travis is super-green |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And counter/datatype operations. NOTE: depends on riak-2.2.5
node_confirms feature.
Depends on:
basho/riak_pb#228
Depended on:
basho/riak_kv#1663