-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add node_confirms
option to write messages
#228
Merged
russelldb
merged 8 commits into
basho:develop-2.2
from
nhs-riak:feature/rdb/node-confirms
Feb 27, 2018
Merged
Add node_confirms
option to write messages
#228
russelldb
merged 8 commits into
basho:develop-2.2
from
nhs-riak:feature/rdb/node-confirms
Feb 27, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of setting up for the 2.2.5 release I made a temp branch off the last released tag, this takes that branch back into the branch the tag was cut from.
Move deps to merged master from temp 2.2.5 dev
For KV/counter/datatypes all
This was referenced Feb 22, 2018
bryanhuntesl
approved these changes
Feb 26, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if it compiles and runs
+1 |
1 similar comment
+1 |
Merging, to give REC a chance to pass CI. |
ThomasArts
pushed a commit
to Quviq/riak_pb
that referenced
this pull request
Mar 18, 2019
* Move deps to merged master from temp 2.2.5 dev As part of setting up for the 2.2.5 release I made a temp branch off the last released tag, this takes that branch back into the branch the tag was cut from. * Add `node_confirms` option to write messages For KV/counter/datatypes all
ThomasArts
pushed a commit
to Quviq/riak_pb
that referenced
this pull request
Mar 18, 2019
* develop-3.0-lower: protobuffs should not be in riak_pb.app.src Fix eqc tests and rebar3 plugin Adapt code for gpb vs erlang_protobuff differences Switch to rebar3 and prepare for OTP20 update rebar/relnotes for 2.2.5 release Add `node_confirms` option to write messages (basho#228) Move deps back to branches for develop-2.2 add gsets support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For KV/counter/datatypes all
required by basho/riak_kv#1663