Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node_confirms option to write messages #228

Merged
merged 8 commits into from
Feb 27, 2018
Merged

Add node_confirms option to write messages #228

merged 8 commits into from
Feb 27, 2018

Conversation

russelldb
Copy link
Member

@russelldb russelldb commented Feb 22, 2018

For KV/counter/datatypes all

required by basho/riak_kv#1663

Copy link

@bryanhuntesl bryanhuntesl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if it compiles and runs

@bryanhuntesl
Copy link

+1

1 similar comment
@martincox
Copy link
Contributor

+1

@russelldb
Copy link
Member Author

Merging, to give REC a chance to pass CI.

@russelldb russelldb merged commit 5a6bcbc into basho:develop-2.2 Feb 27, 2018
@russelldb russelldb deleted the feature/rdb/node-confirms branch February 27, 2018 09:05
ThomasArts pushed a commit to Quviq/riak_pb that referenced this pull request Mar 18, 2019
* Move deps to merged master from temp 2.2.5 dev

As part of setting up for the 2.2.5 release I made a temp branch off the
last released tag, this takes that branch back into the branch the tag
was cut from.

* Add `node_confirms` option to write messages

For  KV/counter/datatypes all
ThomasArts pushed a commit to Quviq/riak_pb that referenced this pull request Mar 18, 2019
* develop-3.0-lower:
  protobuffs should not be in riak_pb.app.src
  Fix eqc tests and rebar3 plugin
  Adapt code for gpb vs erlang_protobuff differences
  Switch to rebar3 and prepare for OTP20
  update rebar/relnotes for 2.2.5 release
  Add `node_confirms` option to write messages (basho#228)
  Move deps back to branches for develop-2.2
  add gsets support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants