Respect --symlink_prefix bazel setting #168
Comments
excavador
changed the title
|
I think the best way to ignore these is adding There are too many complications around Bazel rc files for Gazelle to parse them and figure this automatically. They can be stored in several different places (some checked in, some not), and flags can be conditional (depending on the configuration). |
|
@jayconrod nice workaround, thank you, but would be great to have direct solution. |
|
As of now, the |
rickystewart
added a commit
to rickystewart/cockroach
that referenced
this issue
May 26, 2021
tests. Since then, we've seen `gazelle` occasionally time out lint jobs in CI (see cockroachdb#65715). The error messages don't make a great deal of sense; a bunch of them look like this: gazelle: found packages exports (exports.go) and p (issue20046.go) in /go/src/github.com/cockroachdb/cockroach/_bazel/bin/pkg/testutils/lint/passes/forbiddenmethod/forbiddenmethod_test_/forbiddenmethod_test.runfiles/go_sdk/src/go/internal/gcimporter/testdata i.e., Gazelle is looking in `_bazel/bin`, finding `testdata` for the `go/internal/gcimporter` package in the `go_sdk`, and complaining about the results. So we add `_bazel` to the list of `exclude`s to prevent this. This is necessary according to bazel-contrib/bazel-gazelle#168. Release note: None
craig bot
pushed a commit
to cockroachdb/cockroach
that referenced
this issue
May 26, 2021
64029: roachprod: remove support for spinning up cassandra clusters r=jlinder a=alan-mas When working on #47567, we discovered that the cassandra cluster support is no longer used and can be removed. This commit removes cassandra cluster support. Release note: None 65705: settings: mark diagnostics.forced_stat_reset.interval as retired r=otan a=rafiss It was removed in ac3c723 but was never added to this list. This prevents noise in the logs when trying to read the old setting name. Release note: None 65732: bazel: exclude `_bazel` from consideration by gazelle r=rail a=rickystewart tests. Since then, we've seen `gazelle` occasionally time out lint jobs in CI (see #65715). The error messages don't make a great deal of sense; a bunch of them look like this: gazelle: found packages exports (exports.go) and p (issue20046.go) in /go/src/github.com/cockroachdb/cockroach/_bazel/bin/pkg/testutils/lint/passes/forbiddenmethod/forbiddenmethod_test_/forbiddenmethod_test.runfiles/go_sdk/src/go/internal/gcimporter/testdata i.e., Gazelle is looking in `_bazel/bin`, finding `testdata` for the `go/internal/gcimporter` package in the `go_sdk`, and complaining about the results. So we add `_bazel` to the list of `exclude`s to prevent this. This is necessary according to bazel-contrib/bazel-gazelle#168. Release note: None Co-authored-by: Alanmas <acostas.alan@gmail.com> Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com> Co-authored-by: Ricky Stewart <ricky@cockroachlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If configure bazel (tools/bazel.rc) by following option:
gazelle will try to inspect bazel directories.
Need to respect this option in some way.
For start would be enough add option to 'gazelle' run rule.
The text was updated successfully, but these errors were encountered: