yq: Fix path resolution for external targets #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Northey <ryan@synca.io>
|
|
alexeagle
reviewed
Sep 25, 2023
| bin_dir = "/".join([ctx.bin_dir.path, ctx.label.package]) if ctx.label.package else ctx.bin_dir.path | ||
| bin_dir = ctx.bin_dir.path | ||
| if ctx.label.workspace_name: | ||
| bin_dir = "%s/external/%s" % (bin_dir, ctx.label.workspace_name) |
There was a problem hiding this comment.
this doesn't work with --nolegacy_external_runfiles.
|
It might be a good idea to file an issue for this first, in case others want to contribute a fix for it. |
i proposed a fix as this is blocking us from being able to do some external builds - so was hoping for a quick turnaround and needed something in the interim that works |
phlax
added a commit
to phlax/envoy
that referenced
this pull request
Oct 24, 2023
upstream issue is bazel-contrib/bazel-lib#548 pr is: bazel-contrib/bazel-lib#547 Currently the websites and archive patch this indepenendently This caused a breakage (in all 3) when aspect lib was updated envoyproxy/envoy-website#368 This should prevent that until there is some upstream resolution Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
added a commit
to envoyproxy/envoy
that referenced
this pull request
Oct 24, 2023
bazel/patch: Patch aspect lib to resolve external build issue upstream issue is bazel-contrib/bazel-lib#548 pr is: bazel-contrib/bazel-lib#547 Currently the websites and archive patch this indepenendently This caused a breakage (in all 3) when aspect lib was updated envoyproxy/envoy-website#368 This should prevent that until there is some upstream resolution Signed-off-by: Ryan Northey <ryan@synca.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
yqtarget is unusable if called from an external build, this should resolve thatType of change
For changes visible to end-users
Test plan