-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
py/tools: Namespace repo packages to prevent conflict #29787
Conversation
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
this requires an upstream fix bazel-contrib/bazel-lib#547 it also has a really dirty hack (repeated) - its v similar to the ones we used to have to patch breaking out bits of here as they are resolved (eg #29786) - downstream target is envoyproxy/envoy-website#336 |
67c6672
to
72c0ae2
Compare
4512e1d
to
8880b15
Compare
@htuch this is what is left to make the external docs/protodoc build work essentially the problem boils down to the fact that we have pip deps that are namespaced not sure how best to resolve - not as current in this Pr - at least without some cleanup - will try and follow up one way or anotherr - for now the website is carrying the patch from this pr |
98e83b5
to
0d343b7
Compare
42ddabc
to
5f16d71
Compare
3ebbba1
to
4ebf12d
Compare
this should work now and is a i think a much more elegant/reliable/bazelish solution essentially it injects namespaced init.py into all the places that were making it impossible to use tooling externally i may have missed a couple but this will at least allow external building of docs, and use of most of the linting tools |
Signed-off-by: Ryan Northey <ryan@synca.io>
4ebf12d
to
4103a03
Compare
Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: phlax <phlax@users.noreply.github.com>
Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: phlax <phlax@users.noreply.github.com>
Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: phlax <phlax@users.noreply.github.com>
Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: phlax <phlax@users.noreply.github.com>
This allows repo tooling to work externally alongside our namepsaced pypi packages
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]