-
-
Notifications
You must be signed in to change notification settings - Fork 10
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: windows functionality and tests (#334)
There are four issues when running on windows: 1. #330 2. #331 3. #332 4. #333 This PR fixes 3 and 4. There are related PRs in bazel-skylib and bazel-starlib. There is no dependency -- the PRs can close in any order. - cgrindel/bazel-starlib#446 (fixes 1) - bazelbuild/bazel-skylib#527 (fixes 2) ### Test results: Before: --enable_runfiles: 0 pass --noenable_runfiles: 0 pass After this PR: --enable_runfiles: 52 pass, 19 failures --noenable_runfiles: 51 pass, 20 failures (17 are doc diff-tests due to bazel-starlib) After this PR, together with wip PRs for 1 and 2: --enable_runfiles: 71 pass, 0 failures --noenable_runfiles: 51 pass, 20 failures (all due to bazel-starlib)
- Loading branch information
1 parent
2d514c3
commit b40e501
Showing
4 changed files
with
62 additions
and
20 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters