Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests fail on windows with 'FINDSTR: /= ignored' #331

Open
peakschris opened this issue Jun 28, 2024 · 1 comment
Open

Tests fail on windows with 'FINDSTR: /= ignored' #331

peakschris opened this issue Jun 28, 2024 · 1 comment
Assignees
@peakschris
Labels
enhancement New feature or request

Comments

@peakschris
Copy link
Contributor

Around 45 tests in this repo are failing on windows with what looks like the same underlying issue:

INFO: From Testing //bazel_integration_test/private:bzlformat_no_deps_utils_bzl_fmttest:
==================== Test output for //bazel_integration_test/private:bzlformat_no_deps_utils_bzl_fmttest:
FINDSTR: /= ignored
FINDSTR: /" ignored
FINDSTR: /= ignored
FINDSTR: /" ignored
FAIL: files "bazel_integration_test/private/no_deps_utils.bzl" and "bazel_integration_test/private/no_deps_utils.bzl.formatted" differ.
================================================================================

To reproduce, windows 10:

git clone
cd rules_bazel_integration_test
bazel test //bazel_integration_test/private:bzlformat_no_deps_utils_bzl_fmttest
bazel clean
bazel --windows_enable_symlinks test //bazel_integration_test/private:bzlformat_no_deps_utils_bzl_fmttest
bazel clean
bazel --windows_enable_symlinks test //bazel_integration_test/private:bzlformat_no_deps_utils_bzl_fmttest --enable_runfiles

At a minimum I believe the last invocation should be supported.

I can contribute a fix to this, if it would help.
@peakschris peakschris mentioned this issue Jun 29, 2024
Merged
@cgrindel cgrindel added the enhancement New feature or request label Jun 29, 2024
@cgrindel
Copy link
Member

I marked this as an enhancement as it is adding Windows support. Thanks for the contributions!

cgrindel pushed a commit that referenced this issue Jul 3, 2024
@peakschris
fix: windows functionality and tests (#334)
b40e501 
There are four issues when running on windows:

1.
#330
2.
#331
3.
#332
4.
#333

This PR fixes 3 and 4.

There are related PRs in bazel-skylib and bazel-starlib. There is no
dependency -- the PRs can close in any order.
- cgrindel/bazel-starlib#446 (fixes 1)
- bazelbuild/bazel-skylib#527 (fixes 2)

### Test results:
Before:
--enable_runfiles: 0 pass
--noenable_runfiles: 0 pass

After this PR:
--enable_runfiles: 52 pass, 19 failures
--noenable_runfiles: 51 pass, 20 failures (17 are doc diff-tests due to
bazel-starlib)

After this PR, together with wip PRs for 1 and 2:
--enable_runfiles: 71 pass, 0 failures
--noenable_runfiles: 51 pass, 20 failures (all due to bazel-starlib)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peakschris peakschris

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cgrindel @peakschris