Move resource generation below framework vfs #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves resource generation (and being added to `deps`) below the `framework_vfs` creation which uses the `deps` With the change in #879 to add the vfs to the `swiftc_inputs` instead of the `deps` of the `swift_library` the `framework_vfs` was now also forwarding the resources (because it gets added to `deps` after generation) to other rules (like `rules_xcodeproj`) which collect extra files from this the `swiftc_inputs` attr. AFAIK resources aren't needed for the `framework_vfs` rules and so this change should resolve the new `rules_xcodeproj` incompatibility while making the `deps` to the `framework_vfs` more scoped.
luispadron
force-pushed
the
luis/move-resource-generation-below-vfs
branch
from
c18a6d7
to
b76f03e
Compare
thiagohmcruz
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves resource generation (and being added to
deps) below theframework_vfscreation which uses thedepsWith the change in #879 to add the vfs to the
swiftc_inputsinstead of thedepsof theswift_librarytheframework_vfswas now also forwarding the resources (because it gets added todepsafter generation) to other rules (likerules_xcodeproj) which collect extra files from this theswiftc_inputsattr. This led to duplicated resources in the project as they're collected fromresourcesand now the transitivedepsof theframework_vfsAFAIK resources aren't needed for the
framework_vfsrules and so this change should resolve the newrules_xcodeprojincompatibility while making thedepsto theframework_vfsmore scoped.