Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move resource generation below framework vfs #880

Merged
merged 1 commit into from
Jul 9, 2024

Commits on Jul 5, 2024

  1. Move resource generation below framework vfs

    This moves resource generation (and being added to `deps`) below the `framework_vfs` creation which uses the `deps`
    
    With the change in #879 to add the vfs to the `swiftc_inputs`  instead of the `deps` of the `swift_library` the `framework_vfs` was now also forwarding the resources (because it gets added to `deps` after generation) to other rules (like `rules_xcodeproj`) which collect extra files from this the `swiftc_inputs` attr.
    
    AFAIK resources aren't needed for the `framework_vfs` rules and so this change should resolve the new `rules_xcodeproj` incompatibility while making the `deps` to the `framework_vfs` more scoped.
    luispadron committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    b76f03e View commit details
    Browse the repository at this point in the history