Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add blog post for 5.0 release #263

Merged
merged 4 commits into from
Jan 19, 2022
Merged

add blog post for 5.0 release #263

merged 4 commits into from
Jan 19, 2022

Conversation

Wyverald
Copy link
Member

No description provided.

@Wyverald Wyverald marked this pull request as ready for review January 19, 2022 13:57
@Wyverald Wyverald mentioned this pull request Jan 19, 2022
Closed
9 tasks
aiuto
aiuto suggested changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@aiuto aiuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should get Ivo to take a look for wording around rule to starlark changes.

_posts/2022-01-19-bazel-5.0.md Outdated Show resolved Hide resolved
_posts/2022-01-19-bazel-5.0.md Outdated Show resolved Hide resolved
_posts/2022-01-19-bazel-5.0.md Outdated Show resolved Hide resolved
_posts/2022-01-19-bazel-5.0.md Outdated Show resolved Hide resolved
_posts/2022-01-19-bazel-5.0.md Outdated Show resolved Hide resolved
@aiuto aiuto requested a review from comius January 19, 2022 15:55
@Wyverald
Copy link
Member Author

You should get Ivo to take a look for wording around rule to starlark changes.

For the record, everything in that section was reviewed/rewritten by Ivo in the draft release notes doc.

@hicksjoseph
Copy link
Contributor

LGTM once everyone else's comments have been addressed.

@Wyverald Wyverald merged commit 8d3cf1e into bazelbuild:master Jan 19, 2022
@Wyverald Wyverald deleted the 5.0-post branch January 19, 2022 21:39
@Wyverald
Copy link
Member Author

Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaronsummers jaronsummers jaronsummers left review comments

@aiuto aiuto aiuto approved these changes

@floriographygoth floriographygoth Awaiting requested review from floriographygoth

@hicksjoseph hicksjoseph Awaiting requested review from hicksjoseph

@jin jin Awaiting requested review from jin jin is a code owner

@comius comius Awaiting requested review from comius

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Wyverald @hicksjoseph @aiuto @jaronsummers