Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 5.0 - January 2022 #14013

Closed
9 tasks done
Wyverald opened this issue Sep 20, 2021 · 61 comments
Closed
9 tasks done

Release 5.0 - January 2022 #14013

Wyverald opened this issue Sep 20, 2021 · 61 comments
Assignees
@Wyverald
Labels
P1 I'll work on this now. (Assignee required) release team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website type: process

Comments

@Wyverald
Copy link
Member

Wyverald commented Sep 20, 2021 •
edited
Loading

Status of Bazel 5.0

To report a release-blocking bug, please add it to the 5.0 release blocker milestone, and cc me.

Task list:
@Wyverald Wyverald added P1 I'll work on this now. (Assignee required) type: process release labels Sep 20, 2021
@Wyverald Wyverald self-assigned this Sep 20, 2021
@aaliddell
Copy link
Contributor

Would you consider looking at #7386 for Bazel 5? This was missed as a change on Bazel 4 and has been tripping people up for a long time. The proposed steps to change the default were begun with the addition of an incompatible flag but have got stuck there. Perhaps we can now move to flipping the default to disabling the creation of __init__.py files?

But perhaps this is too short notice now?

@danieljanes
Copy link

...and (related to @aaliddell's comment above): #12238

@Wyverald
Copy link
Member Author

Thanks for flagging this; I'll check with @brandjon.

Although yeah, the purpose of this thread is more on the side of making sure any in-flight changes can make it into 5.0, rather than start prioritizing stuff now. Nevertheless, I see that this has been a long-standing issue, so let's see if we have the cycles to make it happen. (Alternatively, feel free to send PRs if you have the time!)

@philwo philwo added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Sep 21, 2021
@philwo philwo pinned this issue Sep 21, 2021
@philwo philwo changed the title Tracking issue for Bazel 5.0 release Release 5.0 - November 2021 Sep 21, 2021
@Wyverald
Copy link
Member Author

re: __init__.py, please see @brandjon's update at #7386 (comment)

@matthewjh
Copy link

What about #13879?

@Wyverald
Copy link
Member Author

I'll check with @coeuvre.

@quval quval mentioned this issue Sep 30, 2021
Closed
@philwo
Copy link
Member

philwo commented Oct 1, 2021

Please add (potential) release blockers to this milestone: https://github.com/bazelbuild/bazel/milestone/31

@quval
Copy link
Contributor

quval commented Oct 5, 2021

I'm still hoping that #14011 can make the cut – it's been open for a while already been pre-reviewed by @oquenchil (see discussion on #13819), so hopefully there's not much work left before it can be merged.

@quval
Copy link
Contributor

quval commented Oct 5, 2021

Thanks, @philwo – not sure I'd say it's a release blocker, I'm just hoping to get that bug fixed :)

@philwo
Copy link
Member

philwo commented Oct 5, 2021

Yeah, let's just put it on the list so we don't forget about it 😊 Easier to track open PRs / issues in a milestone than a free-form text like here. If it turns out to be too difficult to merge, we can push it back to the backlog.

@dws
Copy link
Contributor

dws commented Oct 18, 2021

Will #7260 (incompatible_enable_cc_toolchain_resolution: Turn on toolchain resolution for cc rules) be resolved in 5.0? I see that it's still open, but tagged with breaking-change-5.0.

@Wyverald
Copy link
Member Author

@dws see there for an update; we're postponing it.

@brentleyjones
Copy link
Contributor

It would be nice to get these in for Apple Silicon support:

@Wyverald
Copy link
Member Author

@brentleyjones the branch cut was supposed to be today, so unlikely that we can get those in.

@Wyverald
Copy link
Member Author

Status update: The branch cut was supposed to be today, but our downstream pipeline was too red to be a good candidate. We'll look through the breakages and determine whether most of them are non-Bazel issues, and try again tomorrow.

@brentleyjones
Copy link
Contributor

@Wyverald I guess cherry-picks?

@Wyverald
Copy link
Member Author

@brentleyjones It's definitely possible to cherrypick those, and especially since it's looking like the branch cut will be delayed further anyhow.

@Wyverald
Copy link
Member Author

Update: Some last-minute issues popped up, which means that the branch cut is going to be delayed to next week.

@keith keith mentioned this issue Oct 21, 2021
Closed
3 tasks
@Wyverald
Copy link
Member Author

Update: The 5.0 release baseline has been cut. I'm wrangling release notes right now (there's quite a lot); will send an announcement email once that's done, and cherrypick requests will be accepted from then on.

@limdor
Copy link
Contributor

limdor commented Oct 26, 2021

Update: The 5.0 release baseline has been cut. I'm wrangling release notes right now (there's quite a lot); will send an announcement email once that's done, and cherrypick requests will be accepted from then on.

Does this mean that there will be a release without release candidate or I just missed the release candidate and I was not aware?

@Wyverald
Copy link
Member Author

There will be release candidates (where else would we cherrypick commits to? :P). I'm just preparing the first RC. All 5.0 RCs and the eventual 5.0 release share a baseline commit; that's what I meant by "The 5.0 release baseline has been cut".

@Wyverald Wyverald changed the title Release 5.0 - November 2021 Release 5.0 - December 2021 Dec 7, 2021
@brentleyjones
Copy link
Contributor

We are down to 0 known release blockers 😄

@Wyverald
Copy link
Member Author

RC3 is out. Hopefully this is the one :)

@Wyverald
Copy link
Member Author

Hi all, since we're approaching the end of the year and the holidays are upon us, and we still have a couple of outstanding release blockers in RC3, we've decided to postpone the release of 5.0 to next year. I've updated the release date tentatively to 2022-01-10.

(the previous comment aged rather poorly, alas)

@Wyverald Wyverald changed the title Release 5.0 - December 2021 Release 5.0 - January 2022 Dec 20, 2021
@Yannic
Copy link
Contributor

Yannic commented Dec 24, 2021

Could we get in #14333 and #14455 please once they are merged?

@fmeum
Copy link
Collaborator

fmeum commented Dec 24, 2021

@meteorcloudy @Wyverald Should #14447 be cherry-picked to prevent a scenario where some Bazel modules don't work (and possibly can't be made to work) with Bazel 5.0.0?

@fmeum
Copy link
Collaborator

fmeum commented Dec 30, 2021

@Wyverald I have found another potential release blocker: #14500.

@Wyverald
Copy link
Member Author

Wyverald commented Jan 3, 2022

@Yannic: Those two changes seem small enough that we can cherrypick them.

@fmeum: #14447 is a bit too big to cherrypick IMO. We should look at fixing backwards compatibility with 5.0 some other way (eg. having a branch in the BCR). #14500 should probably be cherrypicked as it's a regression.

@fmeum
Copy link
Collaborator

fmeum commented Jan 3, 2022 •
edited
Loading

@fmeum: #14447 is a bit too big to cherrypick IMO. We should look at fixing backwards compatibility with 5.0 some other way (eg. having a branch in the BCR).

I agree with being careful as not to delay the release any further. We should keep in mind though that there might not be usable workarounds for the lack of these select's in macros in all cases, so a BCR branch might not help. Maybe ensuring that this gets into 5.1.0 is better.

@brentleyjones
Copy link
Contributor

Since 5.0 includes many Apple Silicon related fixes, in particular iOS arm64 simulator support, it would be nice to get #14439 in as well, which adds watchOS arm64 and tvOS arm64 simulator support.

@siggisim siggisim mentioned this issue Jan 5, 2022
Closed
@meteorcloudy
Copy link
Member

@brentleyjones I prefer not to delay the release of 5.0 by cherry-picking more features (which are not even yet merged), but we can maybe consider it in 5.1.

@brentleyjones
Copy link
Contributor

Understood.

@EdSchouten
Copy link
Contributor

#14471 <- Would this change be eligible for cherry-picking?

@Wyverald
Copy link
Member Author

Wyverald commented Jan 5, 2022

In general, if it's not a regression in 5.0 (compared to say 4.2), I'm reluctant to cherrypick it at this stage. It's not immediately clear to me whether #14471 is fixing a regression or an old bug.

@ptarjan
Copy link
Contributor

ptarjan commented Jan 6, 2022 •
edited
Loading

I'm trying out the 5.0rc3 at Robinhood's monorepo and it is causing some weirdness with baseline_coverage.dat #14521

@Wyverald
Copy link
Member Author

Update: The 5.0 release binaries have now been pushed. Documentation generation and the blog post are still in progress.

In the meantime, @vbatts @petemounce @excitoon could you update the relevant packages in Chocolatey, Scoop, etc.?

@brentleyjones brentleyjones mentioned this issue Jan 19, 2022
Merged
@petemounce
Copy link
Contributor

Pushed!

bazel-io pushed a commit that referenced this issue Jan 19, 2022
@Wyverald @copybara-github
Update 5.0.0 docs
10e3f5e 
#14013

PiperOrigin-RevId: 422828731
@brentleyjones
Copy link
Contributor

What the process for 5.0.1 or 5.1? There were some changes that didn't get cherry-picked into 5.0 that would be nice to get into a branch sooner rather than later (as to not forget about them).

@Wyverald
Copy link
Member Author

We're probably going to create a new milestone for 5.0.1, and one for 5.1 as well. For now, please ping me in those issues and I'll add them to the appropriate lists later.

@blorente
Copy link

blorente commented Feb 3, 2022

@Wyverald I've filed an issue for one such change (#14701), please let me know if this was not the appropriate way.

@Wyverald Wyverald unpinned this issue Feb 3, 2022
@vbatts
Copy link

vbatts commented Feb 14, 2022 via email

@vbatts
Copy link

vbatts commented Feb 15, 2022 via email

@Wyverald
Copy link
Member Author

Thanks, Vincent! Let's track this build failure in #14819

@Wyverald Wyverald mentioned this issue Nov 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wyverald Wyverald

Labels
P1 I'll work on this now. (Assignee required) release team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website type: process
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests