Skip to content

Commit

Permalink
Declare support for gcc_quoting_for_param_files feature in Unix cc_…
Browse files Browse the repository at this point in the history
…toolchain

This was missed with a9e5a32. Without this change, `gcc_quoting_for_param_files` does nothing, because `FeatureConfiguration.isEnabled()` will always return false. Without `gcc_quoting_for_param_files`, linking can fail for files with spaces in them.

Closes #21699.

PiperOrigin-RevId: 617092387
Change-Id: Ifcd4378d2120e2e75e2e72a4b0059b41ba5ce833
  • Loading branch information
brentleyjones authored and copybara-github committed Mar 19, 2024
1 parent fb649d3 commit bd2da6e
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions tools/cpp/unix_cc_toolchain_config.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,11 @@ def _impl(ctx):
enabled = True,
)

gcc_quoting_for_param_files_feature = feature(
name = "gcc_quoting_for_param_files",
enabled = True,
)

static_link_cpp_runtimes_feature = feature(
name = "static_link_cpp_runtimes",
enabled = False,
Expand Down Expand Up @@ -1419,6 +1424,7 @@ def _impl(ctx):
asan_feature,
tsan_feature,
ubsan_feature,
gcc_quoting_for_param_files_feature,
static_link_cpp_runtimes_feature,
] + (
[
Expand Down Expand Up @@ -1459,6 +1465,7 @@ def _impl(ctx):
asan_feature,
tsan_feature,
ubsan_feature,
gcc_quoting_for_param_files_feature,
static_link_cpp_runtimes_feature,
] + (
[
Expand Down

0 comments on commit bd2da6e

Please sign in to comment.