Declare support for gcc_quoting_for_param_files feature in Unix cc_toolchain
#21699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…toolchain This was missed with a9e5a32. Without this change, `gcc_quoting_for_param_files` does nothing. Without `gcc_quoting_for_param_files`, linking can fail for files with spaces in them. Signed-off-by: Brentley Jones <github@brentleyjones.com>
github-actions
bot
added
team-Rules-CPP
luispadron
approved these changes
Mar 14, 2024
|
@bazelbuild/triage in case @googlewalt isn't the right person to review this (it was his original change though), can you assign another reviewer? |
googlewalt
approved these changes
Mar 15, 2024
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
|
This is for 7.2.0, correct? |
|
Yes, it's not urgent, but ideally can go into 7.x. |
|
@bazel-io fork 7.2.0 |
bazel-io
removed
the
potential release blocker
iancha1992
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
brentleyjones
deleted the
bj/declare-support-for-gcc_quoting_for_param_files-feature-in-unix-cc_toolchain
branch
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Mar 25, 2024
…toolchain This was missed with a9e5a32. Without this change, `gcc_quoting_for_param_files` does nothing, because `FeatureConfiguration.isEnabled()` will always return false. Without `gcc_quoting_for_param_files`, linking can fail for files with spaces in them. Closes bazelbuild#21699. PiperOrigin-RevId: 617092387 Change-Id: Ifcd4378d2120e2e75e2e72a4b0059b41ba5ce833
Wyverald
pushed a commit
that referenced
this pull request
Apr 2, 2024
…Unix cc_toolchain (#21798) This was missed with a9e5a32. Without this change, `gcc_quoting_for_param_files` does nothing, because `FeatureConfiguration.isEnabled()` will always return false. Without `gcc_quoting_for_param_files`, linking can fail for files with spaces in them. Closes #21699. PiperOrigin-RevId: 617092387 Change-Id: Ifcd4378d2120e2e75e2e72a4b0059b41ba5ce833 Commit bd2da6e Co-authored-by: Brentley Jones <github@brentleyjones.com> Co-authored-by: Ian (Hee) Cha <heec@google.com>
|
The changes in this PR have been included in Bazel 7.2.0 RC1. Please test out the release candidate and report any issues as soon as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was missed with a9e5a32. Without this change,
gcc_quoting_for_param_filesdoes nothing, becauseFeatureConfiguration.isEnabled()will always return false. Withoutgcc_quoting_for_param_files, linking can fail for files with spaces in them.