Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bazel CI: Projects broken in downstream due to cc_proto_library #10588

Closed
meteorcloudy opened this issue Jan 15, 2020 · 4 comments
Closed

Bazel CI: Projects broken in downstream due to cc_proto_library #10588

meteorcloudy opened this issue Jan 15, 2020 · 4 comments
Labels
breakage P1 I'll work on this now. (Assignee required) type: bug

Comments

@meteorcloudy
Copy link
Member

https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/1351

(10:37:59) ERROR: /var/lib/buildkite-agent/builds/bk-docker-p8pd/bazel-downstream-projects/cartographer/cartographer/BUILD.bazel:25:1: in srcs attribute of BazelCcProtoAspect aspect on proto_library rule //cartographer:protos: The 'srcs' attribute of '//cartographer:protos' contains protos for which 'cc_proto_library' shouldn't generate code (external/com_google_protobuf/google/protobuf/empty.proto), in addition to protos for which it should (cartographer/common/proto/ceres_solver_options.proto, cartographer/ground_truth/proto/relations.proto, cartographer/mapping/proto/2d/cell_limits.proto,

Culprit: 4162cc5
@meteorcloudy meteorcloudy added type: bug P1 I'll work on this now. (Assignee required) breakage labels Jan 15, 2020
@meteorcloudy
Copy link
Member Author

I'll rollback the culprit to get a green downstream.

@meteorcloudy
Copy link
Member Author

/cc @buchgr

bazel-io pushed a commit that referenced this issue Jan 15, 2020
@meteorcloudy @copybara-github
Automated rollback of commit 4162cc5.
9db93bc 
*** Reason for rollback ***

Broken Bazel CI in Downstream pipeline
#10588

*** Original change description ***

proto_lang_toolchain: Add original sources of ProtoInfo to blacklistedProtos

Fixes #10484

Closes #10493.

PiperOrigin-RevId: 289828390
@buchgr buchgr assigned buchgr and unassigned buchgr Jan 15, 2020
@Yannic Yannic mentioned this issue Jan 15, 2020
Closed
bazel-io pushed a commit that referenced this issue Jan 15, 2020
@Yannic @copybara-github
Rollforward of commit 4162cc5.
1821bd5 
proto_lang_toolchain: Add original sources of ProtoInfo to blacklistedProtos

This fixes the problem reported in #10588

Fixes #10484

Closes #10592.

PiperOrigin-RevId: 289857885
@Yannic
Copy link
Contributor

Yannic commented Jan 23, 2020

@meteorcloudy is there anything left to do here?

@meteorcloudy
Copy link
Member Author

Nope, this can be closed.

luca-digrazia pushed a commit to luca-digrazia/DatasetCommitsDiffSearch that referenced this issue Sep 4, 2022
Automated rollback of commit 4162cc54ba0b128b616c0bd05b65bf9ad5e66f2e.
9df4274 
    *** Reason for rollback ***

    Broken Bazel CI in Downstream pipeline
    bazelbuild/bazel#10588

    *** Original change description ***

    proto_lang_toolchain: Add original sources of ProtoInfo to blacklistedProtos

    Fixes #10484

    Closes #10493.

    PiperOrigin-RevId: 289828390
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breakage P1 I'll work on this now. (Assignee required) type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@buchgr @meteorcloudy @Yannic