Rollforward of commit 4162cc54ba0b128b616c0bd05b65bf9ad5e66f2e. #10592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dProtos Fixes bazelbuild#10484 Closes bazelbuild#10493. PiperOrigin-RevId: 289411825
|
@Yannic Thanks for the fix! Can you also add a test to prevent the regression? |
|
The downstream looks good! |
|
@meteorcloudy Thanks! Test already added https://github.com/bazelbuild/bazel/pull/10592/files#diff-5fa14f4d43ed29b5b81abeaa02ff11b5R161 |
meteorcloudy
approved these changes
Jan 15, 2020
|
Perfect! I'll merge this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proto_lang_toolchain: Add original sources of ProtoInfo to blacklistedProtos
This fixes the problem reported in #10588
Fixes #10484