-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Concatenation of dict select expressions #12457
Comments
There's inconsistency here:
doesn't work, but these three work:
while intuitively they look equivalent. |
@stepancheg if you look at #114, you will notice that this is incorrect: unless it changed very recently, the |
Implements the Starlark spec addition of bazelbuild/starlark#215. Work towards #12457 Closes #14540. PiperOrigin-RevId: 431737269
Implements the Starlark spec addition of bazelbuild/starlark#215. Work towards bazelbuild#12457 Closes bazelbuild#14540. PiperOrigin-RevId: 431737269
Implements the Starlark spec addition of bazelbuild/starlark#215. Work towards bazelbuild#12457 Closes bazelbuild#14540. PiperOrigin-RevId: 431737269
Starlark has recentely added support for union operations over dictionaries (bazelbuild/starlark#215). The syntax is already supported in bazel as of #14540, but the same operation with selects of dictionaries is still usupported. Related issue: #12457 Closes #15075. PiperOrigin-RevId: 469827107 Change-Id: If82cfaf577db41efc2e9b55af47b0b1710badc10
Implements the Starlark spec addition of bazelbuild/starlark#215. Work towards bazelbuild#12457 Closes bazelbuild#14540. PiperOrigin-RevId: 431737269
Starlark has recentely added support for union operations over dictionaries (bazelbuild/starlark#215). The syntax is already supported in bazel as of bazelbuild#14540, but the same operation with selects of dictionaries is still usupported. Related issue: bazelbuild#12457 Closes bazelbuild#15075. PiperOrigin-RevId: 469827107 Change-Id: If82cfaf577db41efc2e9b55af47b0b1710badc10
Implements the Starlark spec addition of bazelbuild/starlark#215. Work towards bazelbuild#12457 Closes bazelbuild#14540. PiperOrigin-RevId: 431737269
Starlark has recentely added support for union operations over dictionaries (bazelbuild/starlark#215). The syntax is already supported in bazel as of bazelbuild#14540, but the same operation with selects of dictionaries is still usupported. Related issue: bazelbuild#12457 Closes bazelbuild#15075. PiperOrigin-RevId: 469827107 Change-Id: If82cfaf577db41efc2e9b55af47b0b1710badc10
Starlark has recentely added support for union operations over dictionaries (bazelbuild/starlark#215). The syntax is already supported in bazel as of bazelbuild#14540, but the same operation with selects of dictionaries is still usupported. Related issue: bazelbuild#12457 Closes bazelbuild#15075. PiperOrigin-RevId: 469827107 Change-Id: If82cfaf577db41efc2e9b55af47b0b1710badc10
With starlark's support of
|
We are closing this FR with respect to the above commit. Please feel free to reach us for any further information. Thanks ! |
Implements the Starlark spec addition of bazelbuild/starlark#215. Work towards bazelbuild#12457 Closes bazelbuild#14540. PiperOrigin-RevId: 431737269
Starlark has recentely added support for union operations over dictionaries (bazelbuild/starlark#215). The syntax is already supported in bazel as of bazelbuild#14540, but the same operation with selects of dictionaries is still usupported. Related issue: bazelbuild#12457 Closes bazelbuild#15075. PiperOrigin-RevId: 469827107 Change-Id: If82cfaf577db41efc2e9b55af47b0b1710badc10
(Re-reporting on behalf of @sitaktif; see bazelbuild/starlark#114.)
Starlark allows the concatenation of select statements that return lists, such as:
This is very handy when generating code, which commonly happens when writing bazel rules.
Unfortunately, one cannot concatenate selects that return dicts:
as this results in the following error: type 'dict(label, string)' doesn't support select concatenation.
This error is hit both when concatenating a dict and a select(), and when concatenating two select()s.
Related to see bazelbuild/starlark#14.
The text was updated successfully, but these errors were encountered: