Enable passing vars to configure_file with flags during build [BUILD-391] #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Bazel, we can neither concatenate
dict select
(Bazel ticket):nor use select inside a dict:
That's why to enable passing vars to
configure_file
, we have to use list instead of dict.List which is passed to
configure_file
contains vars in the following format:<key>=<value>
. Vars which don't contain equal sign are skipped.I defined a few macros to use
configure_file
in a more elegant way:var
- define varconfig_var
- define var that relies onconfig_setting
config_flag
- define flag along withconfig_setting
PR tested here:
https://github.com/swift-nav/libpal/pull/275
https://github.com/swift-nav/libswiftnav-private/pull/403
https://github.com/swift-nav/gnss-converters-bazel/pull/8