Accept proto_library as //tools/objc:protobuf_well_known_types #12486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of the migration of Protobuf rules/aspects to `ProtoSource`. A future change will make `ProtoInfo` mandatory (similar to what was done for `proto_lang_toolchain`). Note that this is for Obj-C Protobuf rules which don't exist in Bazel. Updates bazelbuild#10005
lberki
approved these changes
Nov 27, 2020
|
Let's see what the presubmit checks say! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the migration of Protobuf rules/aspects to
ProtoSource.A future change will make
ProtoInfomandatory (similar to what wasdone for
proto_lang_toolchain).Note that this is for Obj-C Protobuf rules which don't exist in Bazel.
Updates #10005