Clean up ConfiguredTargetValueAccessor and ConfiguredTargetAccessor #12549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix looking up a target from the walkable graph.
- This prevents ConfiguredTargetValueAccessor from needing to look into
ConfiguredTargetAccessor.
- And removes duplicated code.
- Move CTVA into the correct package.
Part of bazelbuild#11993.
juliexxia
reviewed
Nov 24, 2020
| @@ -159,6 +161,11 @@ public final FilteringQueryFunction asFilteringFunction() { | |||
| public abstract int getExpressionToFilterIndex(); | |||
| } | |||
|
|
|||
| @FunctionalInterface | |||
| interface TargetLookup { | |||
| Target getTarget(Label label) throws TargetNotFoundException, InterruptedException; | |||
There was a problem hiding this comment.
apologies I think I'm missing something - where does this actually get implemented?
There was a problem hiding this comment.
It's a functional interface, so in ActionGraphQueryEnvironment's constructor, the method reference ActionGraphQueryEnvironment::getTarget is used as a TargetLookup and passed into ConfiguredTargetValueAccessor.
There was a problem hiding this comment.
Ah, and AGQE has an inherited getTarget method from PostAnalysisQE. Missed that bit. Thanks!
juliexxia
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConfiguredTargetAccessor.
Part of #11993.