Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order of build request id and command id #13237

Closed
wants to merge 1 commit into from

Conversation

ulfjack
Copy link
Contributor

@ulfjack ulfjack commented Mar 17, 2021

They should be in this order rather than the other way round.

See RemoteServerCapabilities.get.

Change-Id: I4be952cc2ad43ae35c7052bd26b153b1e887e562

They should be in this order rather than the other way round.

Change-Id: I4be952cc2ad43ae35c7052bd26b153b1e887e562
@google-cla google-cla bot added the cla: yes label Mar 17, 2021
@ulfjack
Copy link
Contributor Author

ulfjack commented Mar 18, 2021

Looks like this broke in commit 52c8773, Bazel 3.0.0.

@ulfjack
Copy link
Contributor Author

ulfjack commented Mar 18, 2021

@coeuvre

@coeuvre coeuvre self-requested a review March 19, 2021 05:26
@coeuvre coeuvre added the team-Remote-Exec Issues and PRs for the Execution (Remote) team label Mar 19, 2021
Copy link
Member

@coeuvre coeuvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bazel-io bazel-io closed this in 9a5cd85 Mar 22, 2021
philwo pushed a commit that referenced this pull request Apr 19, 2021
They should be in this order rather than the other way round.

See `RemoteServerCapabilities.get`.

Change-Id: I4be952cc2ad43ae35c7052bd26b153b1e887e562

Closes #13237.

Change-Id: I4be952cc2ad43ae35c7052bd26b153b1e887e562
PiperOrigin-RevId: 364266202
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes team-Remote-Exec Issues and PRs for the Execution (Remote) team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants