Make --nobuild_runfiles_links work in combination with --run_under #14471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When both of these flags are provided, we must make sure that a "bazel run" forcefully instantiates the runfiles directories both for the target to run, and the --run_under target. Right now it only ensures this for the former, which causes execution errors along the lines of: Cannot find .runfiles directory for /some/path This code alters the existing code block that ensures that runfiles exist to loop over the entire set of targets. We do need to capture the path of the runfiles directory of the target to run, as it may need be used as the working directory later on.
janakdr
approved these changes
Dec 25, 2021
justinhorvitz
approved these changes
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When both of these flags are provided, we must make sure that a "bazel
run" forcefully instantiates the runfiles directories both for the
target to run, and the --run_under target. Right now it only ensures
this for the former, which causes execution errors along the lines of:
Cannot find .runfiles directory for /some/path
This code alters the existing code block that ensures that runfiles
exist to loop over the entire set of targets. We do need to capture the
path of the runfiles directory of the target to run, as it may need be
used as the working directory later on.