-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use rules_jvm_external to fetch turbine #19472
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks!
@iancha1992 Can you first import the non-third party change, then the third party change? |
Hi @cushon, Could you please help us in resolving the conflict? |
Instead of checking in a precompiled jar, following the example of bazelbuild#17112
9c886d3
to
aaeeabc
Compare
Done |
Reopen until the third party change is also merged. |
Fix merging of #19472 RELNOTES: None PiperOrigin-RevId: 565033337 Change-Id: Ia4020e87e5cf4f9846b801a2203f4931f1ce5205
The third_party change wasn't merged correctly and was reverted as part of the following commit: 2482322 This currently breaks CI on master. |
Fixed by ea019d4, sorry about the breakage, please rebase. |
This is to facilitate moving the rule implementation out of Bazel itself and into rules_python. This also makes the tests pass when an allowlist is used to enforce that the Python rules are being loaded through rules_python instead of used from builtins. This the same change as before, but with some internal fixes applied. PiperOrigin-RevId: 565113515 Change-Id: I999dbfaace8cce2168e718093fe418d548ab1b73 Partial commit for third_party/*, see #19472. Signed-off-by: Hee Cha <heec@google.com>
This is now merged and the breakage has been fixed. |
Instead of checking in a precompiled jar, following the example of #17112