Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up README #2

Merged
merged 3 commits into from
Jun 20, 2014
Merged

Fix up README #2

merged 3 commits into from
Jun 20, 2014

Conversation

kchodorow
Copy link
Contributor

No description provided.

@kchodorow
Copy link
Contributor Author

It's already there in the instructions:

$ touch tools/genrule/genrule-setup.sh

Create tools/genrule/BUILD and add the following to it:

  exports_files([
      "genrule-setup.sh",
  ])

lberki added a commit that referenced this pull request Jun 20, 2014
@lberki lberki merged commit 5f4be42 into bazelbuild:master Jun 20, 2014
@ulfjack ulfjack mentioned this pull request Mar 27, 2015
bazel-io pushed a commit that referenced this pull request May 4, 2016
Add dagger to third_party in preparation for an upcoming conversion
of the junit test runner from Guice to Dagger.

Part #2: Build file

--
Change-Id: Idae2182c491e01d2f0b5e852a5314e65624592c6
Reviewed-on: https://bazel-review.googlesource.com/#/c/3570/
MOS_MIGRATED_REVID=121500145
bazel-io pushed a commit that referenced this pull request Nov 24, 2016
…r SHA1 digests used with remote execution.

I missed an important test failure -- turned out we have a remote execution
test that does not live under lib/remote.

--
MOS_MIGRATED_REVID=140135277
bazel-io pushed a commit that referenced this pull request May 4, 2017
…pple platform types.

RELNOTES: None.
PiperOrigin-RevId: 154993630
hlopko pushed a commit that referenced this pull request May 23, 2017
…pple platform types.

RELNOTES: None.
PiperOrigin-RevId: 154993630
bazel-io pushed a commit that referenced this pull request May 26, 2017
Baseline: f3ae88e

Cherry picks:
   + c58ba09:
     Release to GCS: put the final release in its own directory
   + 0acead4:
     Update protobuf to latest master at a64497c and apply
     @laszlocsomor's latest changes from
     protocolbuffers/protobuf#2969 on top of it.
   + d0242ce:
     Make symlinks consistent
   + d953ca8:
     Clean VanillaJavaBuilder output directories
   + 755669f:
     Pass all the environment variable to Bazel during bootstrapping
   + 6f04166:
     Do not mark the JDK7 installer -without-jdk-installer
   + 7205611:
     Fix #2958: Installer should not overwrite bazelrc
   + 511c35b:
     Bootstrap: move the fail function to the top
   + 8470be1:
     Clean up javac and Error Prone targets
   + 4a404de:
     Update javac version to 9-dev-r4023-2
   + 36ce4b4:
     Update javac version to 9-dev-r4023-2
   + 38949b8:
     Migrate off versioned javac and Error Prone targets
   + 1a57d29:
     Re-enabling passing -sourcepath via javacopts.
   + eb565f4:
     Make make sure that msys build actually builds msys version
   + 39f328c:
     Fix typo. Also do not override host_cpu for msvc.
   + 6248028:
     Select correct JDK for windows_msys
   + c4f271d:
     Automated g4 rollback of commit
     3e5edaf.
   + 9261809:
     Remove process-tools.cc which I forgot to delete during the last
     rollback.
   + baca6e4:
     Fix #2982: Bazel installer should not check for installed JDK if
     using a bundled JDK.
   + 866ecc8:
     Disable msys path conversion on Windows.
   + cc21998:
     Rollforward #2 of: Basic open-source crosstool to support
     targeting apple platform types.
   + 0f0ccc4:
     Escape % in strings that will appear in Crosstool
   + 3b08f77:
     Adding feature for linking C Run-Time library on Windows

Incompatible changes:

  - Bazel's Linux sandbox no longer mounts an empty tmpfs on /tmp,
    instead the existing /tmp is mounted read-write. If you prefer
    to have a tmpfs on /tmp for sandboxed actions for increased
    hermeticity, please use the flag --sandbox_tmpfs_path=/tmp.
  - Converting artifacts to strings and printing them now return
    "File" instead of "Artifact" to be consistent with the type name.
  - The return type of depset.to_list() is now a list rather than a
    frozen list. (Modifying the list has no effect on the depset.)
  - Bazel now prints logs in single lines to java.log
  - --use_dash, --dash_url and --dash_secret are removed.
  - Remote repositories must define any remote repositories they
    themselves use (e.g., if @x//:foo depends on @y//:bar, @y must be
    defined
    in @x's WORKSPACE file).
  - Remote repositories must define any remote repositories they
    themselves use (e.g., if @x//:foo depends on @y//:bar, @y must be
    defined
    in @x's WORKSPACE file).
  - objc_xcodeproj has been removed, use tulsi.bazel.build instead.

New features:

  - If grte_top is a label, it can now follow non-configurable
    redirects.
  - Optional coverage_files attribute to cc_toolchain
  - "query --output=build" now includes select()s
  - Raw LLVM profiles are now supported.

Important changes:

  - Automatically generate Proguard mapping when resource shrinking
    and Proguard are enabled.
  - New rules in Bazel: proto_library, java_lite_proto_library,
    java_proto_library and cc_proto_library
  - Activate the "dead_strip" feature if objc binary stripping is
    enabled.
  - More stable naming scheme for lambda classes in desugared android
    code
  - Convert --use_action_cache to a regular option
  - Per-architecture dSYM binaries are now propagated by
    apple_binary's AppleDebugOutputsProvider.
  - Avoid factory methods when desugaring stateless lambdas for
    Android
  - desugar calls to Objects.requireNonNull(Object o) with
    o.getClass() for android
  - Add an --copy_bridges_from_classpath argument to android
    desugaring tool
  - Change how desugar finds desugared classes to have it working on
    Windows
  - Evaluation of commands on TargetsBelowDirectory patterns
    (e.g. //foo/...) matching packages that fail to load now report
    more
    detailed error messages in keep_going mode.
  - Allow to have several inputs and outputs
  - Repository context's execute() function can print stdout/stderr
    while running. To enable, pass quiet=False.
  - Bazel can now be built with a bundled version of the OpenJDK.
    This makes it possible to use Bazel on systems without a JDK, or
    where
    the installed JDK is too old.
  - The --jobs flag now defaults to "auto", which causes Bazel to
    use a reasonable degree of parallelism based on the local
    machine's
    capacity.
  - Bazel benchmark (perf.bazel.build) supports Java and Cpp targets.
  - no factory methods generated for lambda expressions on android
  - The Linux sandbox no longer changes the user to 'nobody' by
    default, instead the current user is used as is. The old behavior
    can be
    restored via the --sandbox_fake_username flag.
  - /tmp and /dev/shm are now writable by default inside the
    Linux sandbox.
  - Bazel can now use the process-wrapper + symlink tree based
    sandbox implementation in FreeBSD.
  - turn on --experimental_incremental_dexing_error_on_missed_jars by
    default.
  - All android_binarys are now signed with both Apk Signature V1 and
    V2. See https://source.android.com/security/apksigning/v2.html
    for more details.
  - Windows MSVC wrappers: Not filtering warning messages anymore,
    use --copt=-w and --host_copt=-w to suppress them.
  - A downloader bug was fixed that prevented RFC 7233 Range
    connection resumes from working with certain HTTP servers
  - Introduces experimental android_device rule for configuring and
    launching Android emulators.
  - For boolean flags, setting them to false using --no_<flag_name>
    is deprecated. Use --no<flag_name> without the underscore, or
    --<flag_name>=false instead.
  - Add --experimental_android_compress_java_resources flag to store
    java
    resources as compressed inside the APK.
  - Removed --experimental_use_jack_for_dexing and libname.jack
    output of
    android_library.
  - blaze canonicalize-flags now takes a --show_warnings flag
  - Changing --invocation_policy will no longer force a server
    restart.
  - Bazel now supports Android NDK14.
  - android_binary multidex should now work without additional flags.
  - Use action_config in crosstool for static library archiving,
    remove ar_flag.
  - new option for bazel canonicalize-flags, --canonicalize_policy
  - Use action_config in crosstool for static library archiving,
    remove ar_flag.
  - android_library exports_manifest now defaults to True.
  - Fix select condition intersections.
  - Adds a --override_repository option that takes a repository
    name and path. This forces Bazel to use the directory at that path
    for the repository. Example usage:
    `--override_repository=foo=/home/user/gitroot/foo`.
  - fix idempotency issue with desugaring lambdas in interface
    initializers for android
  - --experimental_android_use_singlejar_for_multidex is now a no-op
    and will eventually be removed.
  - Every local_repository now requires a WORKSPACE file.
  - Remove jack and jill attributes of the android_sdk rule.
  - Add Skylark stubs needed to remove sysroot from CppConfiguration.
  - Desugar try-with-resources so that this language feature is
    available
    to deveces with API level under 19.
  - The flag --worker_max_retries was removed. The
    WorkerSpawnStrategy no longer retries execution of failed Spawns,
    the reason being that this just masks compiler bugs and isn't
    done for any other execution strategy either.
  - Bazel will no longer gracefully restart workers that crashed /
    quit, instead this triggers a build failure.
  - All java resources are now compressed in android_binary APKs by
    default.
  - All java resources are now compressed in android_binary APKs by
    default.
  - android_ndk_repository now creates a cc_library
    (@androidndk//:cpufeatures) for the cpufeatures library that is
    bundled in the Android NDK. See
    https://developer.android.com/ndk/guides/cpu-features.html for
    more details.
  - 'output_groups' and 'instrumented_files' cannot be specified in
    DefaultInfo.
  - You can increase the CPU reservation for tests by adding a
    "cpu:<n>" (e.g. "cpu:4" for four cores) tag to their rule in a
    BUILD file. This can be used if tests would otherwise overwhelm
    your system if there's too much parallelism.
  - Deprecate use_singlejar_for_proguard_libraryjars and force
    behavior to always on.
damienmg pushed a commit that referenced this pull request May 26, 2017
…pple platform types.

RELNOTES: None.
PiperOrigin-RevId: 154993630
juhalindfors pushed a commit to juhalindfors/bazel-patches that referenced this pull request May 27, 2017
Baseline: f3ae88e

Cherry picks:
   + c58ba09:
     Release to GCS: put the final release in its own directory
   + 0acead4:
     Update protobuf to latest master at a64497c and apply
     @laszlocsomor's latest changes from
     protocolbuffers/protobuf#2969 on top of it.
   + d0242ce:
     Make symlinks consistent
   + d953ca8:
     Clean VanillaJavaBuilder output directories
   + 755669f:
     Pass all the environment variable to Bazel during bootstrapping
   + 6f04166:
     Do not mark the JDK7 installer -without-jdk-installer
   + 7205611:
     Fix bazelbuild#2958: Installer should not overwrite bazelrc
   + 511c35b:
     Bootstrap: move the fail function to the top
   + 8470be1:
     Clean up javac and Error Prone targets
   + 4a404de:
     Update javac version to 9-dev-r4023-2
   + 36ce4b4:
     Update javac version to 9-dev-r4023-2
   + 38949b8:
     Migrate off versioned javac and Error Prone targets
   + 1a57d29:
     Re-enabling passing -sourcepath via javacopts.
   + eb565f4:
     Make make sure that msys build actually builds msys version
   + 39f328c:
     Fix typo. Also do not override host_cpu for msvc.
   + 6248028:
     Select correct JDK for windows_msys
   + c4f271d:
     Automated g4 rollback of commit
     3e5edaf.
   + 9261809:
     Remove process-tools.cc which I forgot to delete during the last
     rollback.
   + baca6e4:
     Fix bazelbuild#2982: Bazel installer should not check for installed JDK if
     using a bundled JDK.
   + 866ecc8:
     Disable msys path conversion on Windows.
   + cc21998:
     Rollforward bazelbuild#2 of: Basic open-source crosstool to support
     targeting apple platform types.
   + 0f0ccc4:
     Escape % in strings that will appear in Crosstool
   + 3b08f77:
     Adding feature for linking C Run-Time library on Windows

Incompatible changes:

  - Bazel's Linux sandbox no longer mounts an empty tmpfs on /tmp,
    instead the existing /tmp is mounted read-write. If you prefer
    to have a tmpfs on /tmp for sandboxed actions for increased
    hermeticity, please use the flag --sandbox_tmpfs_path=/tmp.
  - Converting artifacts to strings and printing them now return
    "File" instead of "Artifact" to be consistent with the type name.
  - The return type of depset.to_list() is now a list rather than a
    frozen list. (Modifying the list has no effect on the depset.)
  - Bazel now prints logs in single lines to java.log
  - --use_dash, --dash_url and --dash_secret are removed.
  - Remote repositories must define any remote repositories they
    themselves use (e.g., if @x//:foo depends on @y//:bar, @y must be
    defined
    in @x's WORKSPACE file).
  - Remote repositories must define any remote repositories they
    themselves use (e.g., if @x//:foo depends on @y//:bar, @y must be
    defined
    in @x's WORKSPACE file).
  - objc_xcodeproj has been removed, use tulsi.bazel.build instead.

New features:

  - If grte_top is a label, it can now follow non-configurable
    redirects.
  - Optional coverage_files attribute to cc_toolchain
  - "query --output=build" now includes select()s
  - Raw LLVM profiles are now supported.

Important changes:

  - Automatically generate Proguard mapping when resource shrinking
    and Proguard are enabled.
  - New rules in Bazel: proto_library, java_lite_proto_library,
    java_proto_library and cc_proto_library
  - Activate the "dead_strip" feature if objc binary stripping is
    enabled.
  - More stable naming scheme for lambda classes in desugared android
    code
  - Convert --use_action_cache to a regular option
  - Per-architecture dSYM binaries are now propagated by
    apple_binary's AppleDebugOutputsProvider.
  - Avoid factory methods when desugaring stateless lambdas for
    Android
  - desugar calls to Objects.requireNonNull(Object o) with
    o.getClass() for android
  - Add an --copy_bridges_from_classpath argument to android
    desugaring tool
  - Change how desugar finds desugared classes to have it working on
    Windows
  - Evaluation of commands on TargetsBelowDirectory patterns
    (e.g. //foo/...) matching packages that fail to load now report
    more
    detailed error messages in keep_going mode.
  - Allow to have several inputs and outputs
  - Repository context's execute() function can print stdout/stderr
    while running. To enable, pass quiet=False.
  - Bazel can now be built with a bundled version of the OpenJDK.
    This makes it possible to use Bazel on systems without a JDK, or
    where
    the installed JDK is too old.
  - The --jobs flag now defaults to "auto", which causes Bazel to
    use a reasonable degree of parallelism based on the local
    machine's
    capacity.
  - Bazel benchmark (perf.bazel.build) supports Java and Cpp targets.
  - no factory methods generated for lambda expressions on android
  - The Linux sandbox no longer changes the user to 'nobody' by
    default, instead the current user is used as is. The old behavior
    can be
    restored via the --sandbox_fake_username flag.
  - /tmp and /dev/shm are now writable by default inside the
    Linux sandbox.
  - Bazel can now use the process-wrapper + symlink tree based
    sandbox implementation in FreeBSD.
  - turn on --experimental_incremental_dexing_error_on_missed_jars by
    default.
  - All android_binarys are now signed with both Apk Signature V1 and
    V2. See https://source.android.com/security/apksigning/v2.html
    for more details.
  - Windows MSVC wrappers: Not filtering warning messages anymore,
    use --copt=-w and --host_copt=-w to suppress them.
  - A downloader bug was fixed that prevented RFC 7233 Range
    connection resumes from working with certain HTTP servers
  - Introduces experimental android_device rule for configuring and
    launching Android emulators.
  - For boolean flags, setting them to false using --no_<flag_name>
    is deprecated. Use --no<flag_name> without the underscore, or
    --<flag_name>=false instead.
  - Add --experimental_android_compress_java_resources flag to store
    java
    resources as compressed inside the APK.
  - Removed --experimental_use_jack_for_dexing and libname.jack
    output of
    android_library.
  - blaze canonicalize-flags now takes a --show_warnings flag
  - Changing --invocation_policy will no longer force a server
    restart.
  - Bazel now supports Android NDK14.
  - android_binary multidex should now work without additional flags.
  - Use action_config in crosstool for static library archiving,
    remove ar_flag.
  - new option for bazel canonicalize-flags, --canonicalize_policy
  - Use action_config in crosstool for static library archiving,
    remove ar_flag.
  - android_library exports_manifest now defaults to True.
  - Fix select condition intersections.
  - Adds a --override_repository option that takes a repository
    name and path. This forces Bazel to use the directory at that path
    for the repository. Example usage:
    `--override_repository=foo=/home/user/gitroot/foo`.
  - fix idempotency issue with desugaring lambdas in interface
    initializers for android
  - --experimental_android_use_singlejar_for_multidex is now a no-op
    and will eventually be removed.
  - Every local_repository now requires a WORKSPACE file.
  - Remove jack and jill attributes of the android_sdk rule.
  - Add Skylark stubs needed to remove sysroot from CppConfiguration.
  - Desugar try-with-resources so that this language feature is
    available
    to deveces with API level under 19.
  - The flag --worker_max_retries was removed. The
    WorkerSpawnStrategy no longer retries execution of failed Spawns,
    the reason being that this just masks compiler bugs and isn't
    done for any other execution strategy either.
  - Bazel will no longer gracefully restart workers that crashed /
    quit, instead this triggers a build failure.
  - All java resources are now compressed in android_binary APKs by
    default.
  - All java resources are now compressed in android_binary APKs by
    default.
  - android_ndk_repository now creates a cc_library
    (@androidndk//:cpufeatures) for the cpufeatures library that is
    bundled in the Android NDK. See
    https://developer.android.com/ndk/guides/cpu-features.html for
    more details.
  - 'output_groups' and 'instrumented_files' cannot be specified in
    DefaultInfo.
  - You can increase the CPU reservation for tests by adding a
    "cpu:<n>" (e.g. "cpu:4" for four cores) tag to their rule in a
    BUILD file. This can be used if tests would otherwise overwhelm
    your system if there's too much parallelism.
  - Deprecate use_singlejar_for_proguard_libraryjars and force
    behavior to always on.
hlopko pushed a commit that referenced this pull request May 31, 2017
…pple platform types.

RELNOTES: None.
PiperOrigin-RevId: 154993630
bazel-io pushed a commit that referenced this pull request Jun 6, 2017
Baseline: f3ae88e

Cherry picks:
   + c58ba09:
     Release to GCS: put the final release in its own directory
   + 0acead4:
     Update protobuf to latest master at a64497c and apply
     @laszlocsomor's latest changes from
     protocolbuffers/protobuf#2969 on top of it.
   + d0242ce:
     Make symlinks consistent
   + d953ca8:
     Clean VanillaJavaBuilder output directories
   + 755669f:
     Pass all the environment variable to Bazel during bootstrapping
   + 6f04166:
     Do not mark the JDK7 installer -without-jdk-installer
   + 7205611:
     Fix #2958: Installer should not overwrite bazelrc
   + 511c35b:
     Bootstrap: move the fail function to the top
   + 8470be1:
     Clean up javac and Error Prone targets
   + 4a404de:
     Update javac version to 9-dev-r4023-2
   + 36ce4b4:
     Update javac version to 9-dev-r4023-2
   + 38949b8:
     Migrate off versioned javac and Error Prone targets
   + 1a57d29:
     Re-enabling passing -sourcepath via javacopts.
   + eb565f4:
     Make make sure that msys build actually builds msys version
   + 39f328c:
     Fix typo. Also do not override host_cpu for msvc.
   + 6248028:
     Select correct JDK for windows_msys
   + c4f271d:
     Automated g4 rollback of commit
     3e5edaf.
   + 9261809:
     Remove process-tools.cc which I forgot to delete during the last
     rollback.
   + baca6e4:
     Fix #2982: Bazel installer should not check for installed JDK if
     using a bundled JDK.
   + 866ecc8:
     Disable msys path conversion on Windows.
   + cc21998:
     Rollforward #2 of: Basic open-source crosstool to support
     targeting apple platform types.
   + 0f0ccc4:
     Escape % in strings that will appear in Crosstool
   + 3b08f77:
     Adding feature for linking C Run-Time library on Windows
   + 3566474:
     Do not use sed -E in bootstrap/compile.sh
   + c3cf7d9:
     Reverts non-xcode-available darwin crosstool generation.

Important changes:

  - Fixes regression in 0.5.0 requiring Xcode to build C++ on OSX.
mmorearty referenced this pull request in Asana/bazel Jun 6, 2017
Baseline: f3ae88e

Cherry picks:
   + c58ba09:
     Release to GCS: put the final release in its own directory
   + 0acead4:
     Update protobuf to latest master at a64497c and apply
     @laszlocsomor's latest changes from
     protocolbuffers/protobuf#2969 on top of it.
   + d0242ce:
     Make symlinks consistent
   + d953ca8:
     Clean VanillaJavaBuilder output directories
   + 755669f:
     Pass all the environment variable to Bazel during bootstrapping
   + 6f04166:
     Do not mark the JDK7 installer -without-jdk-installer
   + 7205611:
     Fix bazelbuild#2958: Installer should not overwrite bazelrc
   + 511c35b:
     Bootstrap: move the fail function to the top
   + 8470be1:
     Clean up javac and Error Prone targets
   + 4a404de:
     Update javac version to 9-dev-r4023-2
   + 36ce4b4:
     Update javac version to 9-dev-r4023-2
   + 38949b8:
     Migrate off versioned javac and Error Prone targets
   + 1a57d29:
     Re-enabling passing -sourcepath via javacopts.
   + eb565f4:
     Make make sure that msys build actually builds msys version
   + 39f328c:
     Fix typo. Also do not override host_cpu for msvc.
   + 6248028:
     Select correct JDK for windows_msys
   + c4f271d:
     Automated g4 rollback of commit
     3e5edaf.
   + 9261809:
     Remove process-tools.cc which I forgot to delete during the last
     rollback.
   + baca6e4:
     Fix bazelbuild#2982: Bazel installer should not check for installed JDK if
     using a bundled JDK.
   + 866ecc8:
     Disable msys path conversion on Windows.
   + cc21998:
     Rollforward #2 of: Basic open-source crosstool to support
     targeting apple platform types.
   + 0f0ccc4:
     Escape % in strings that will appear in Crosstool
   + 3b08f77:
     Adding feature for linking C Run-Time library on Windows
   + 3566474:
     Do not use sed -E in bootstrap/compile.sh
   + c3cf7d9:
     Reverts non-xcode-available darwin crosstool generation.

Important changes:

  - Fixes regression in 0.5.0 requiring Xcode to build C++ on OSX.
bazel-io pushed a commit that referenced this pull request Aug 31, 2017
…gate unwrapped ObjcProvider", after changes made to apple bazel rules to be compatible.

RELNOTES: None.
PiperOrigin-RevId: 167061765
bazel-io pushed a commit that referenced this pull request Sep 4, 2017
*** Reason for rollback ***

Broke several tests in nightly.

[]

*** Original change description ***

Rollforward #2 of "AppleBinary and AppleStaticLibrary no longer propagate unwrapped ObjcProvider", after changes made to apple bazel rules to be compatible.

RELNOTES: None.
PiperOrigin-RevId: 167312716
bazel-io pushed a commit that referenced this pull request Jun 2, 2020
…ramdown, attempt #2

Rollforward after redirect pages have been fixed by 565f774. Fixes #11451

RELNOTES:
PiperOrigin-RevId: 314288440
bazel-io pushed a commit that referenced this pull request Jun 2, 2020
*** Reason for rollback ***

Still broken: https://docs.bazel.build/versions/3.2.0/index.html

*** Original change description ***

Migrate docs.bazel.build to use GitHub Flavored Markdown instead of Kramdown, attempt #2

Rollforward after redirect pages have been fixed by 565f774. Fixes #11451

RELNOTES:
PiperOrigin-RevId: 314304669
philwo added a commit that referenced this pull request Sep 29, 2020
Seen in GCB:

Step #2:   Conversion error: Jekyll::Converters::Scss encountered an error while converting 'css/main.scss':
Step #2:                     Invalid US-ASCII character "\xC2" on line 68
Step #2: jekyll 3.8.7 | Error:  Invalid US-ASCII character "\xC2" on line 68

This should fix it.
bazel-io pushed a commit that referenced this pull request Oct 2, 2020
Seen in GCB:

```
Step #2:   Conversion error: Jekyll::Converters::Scss encountered an error while converting 'css/main.scss':
Step #2:                     Invalid US-ASCII character "\xC2" on line 68
Step #2: jekyll 3.8.7 | Error:  Invalid US-ASCII character "\xC2" on line 68
```

This should fix it.

Closes #12187.

PiperOrigin-RevId: 335005755
@vpanta vpanta mentioned this pull request Apr 1, 2022
zachgrayio referenced this pull request in flarebuild/bazel Apr 6, 2022
use flare cache directly instead of cdn
lfpino added a commit to lfpino/bazel that referenced this pull request Jul 5, 2022
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
copybara-service bot pushed a commit that referenced this pull request Sep 13, 2023
This is to facilitate moving the rule implementation out of Bazel itself and into rules_python. This also makes the tests pass when an allowlist is used to enforce that the Python rules are being loaded through rules_python instead of used from builtins.

This the same change as before, but with some internal fixes applied.

PiperOrigin-RevId: 565113515
Change-Id: I999dbfaace8cce2168e718093fe418d548ab1b73
copybara-service bot pushed a commit that referenced this pull request Sep 13, 2023
This is to facilitate moving the rule implementation out of Bazel itself and into rules_python. This also makes the tests pass when an allowlist is used to enforce that the Python rules are being loaded through rules_python instead of used from builtins.

This the same change as before, but with some internal fixes applied.

PiperOrigin-RevId: 565113515
Change-Id: I999dbfaace8cce2168e718093fe418d548ab1b73

Partial commit for third_party/*, see #19472.

Signed-off-by: Hee Cha <heec@google.com>
copybara-service bot pushed a commit that referenced this pull request Oct 10, 2023
… order.

1. `TestAttempt` events would wait for the `TargetCompleteEvent` to be posted before being posted.

2. There was an implicit requirement for the `TestAttempt` events to be posted in a specific order.

3. This didn't break in the noskymeld case because we fulfilled this ordering by using the order of performing the attempts themselves. The sequence would look like:
    + post `TargetCompleteEvent`
    -> perform attempt #1
    -> post `TestAttempt` #1
    -> perform attempt #2
    -> post `TestAttempt` #2

4. With skymeld, however, it could happen like this:

    + defer `TargetCompleteEvent` to wait for `CoverageActionFinishedEvent`
    + perform attempt #1 -> defer posting `TestAttempt` #1 & wait for `TargetCompleteEvent`
    + perform attempt #2 -> defer posting `TestAttempt` #2 & wait for `TargetCompleteEvent`
    + `CoverageActionFinishedEvent` -> release & post `TargetCompleteEvent`
    + `TargetCompleteEvent` -> release & post `TestAttempt` #2
    + `TargetCompleteEvent` -> release & post `TestAttempt` #1

Due to (2), the undefined ordering in (4) would cause an issue.

This CL fixes that by ensuring a FIFO ordering of the deferred events.

PiperOrigin-RevId: 572165337
Change-Id: Iac4d023d946865b8b81f15b119417192dc4b5c53
hvadehra added a commit that referenced this pull request Nov 3, 2023
hvadehra added a commit that referenced this pull request Nov 3, 2023
hvadehra added a commit that referenced this pull request Nov 3, 2023
copybara-service bot pushed a commit that referenced this pull request Feb 27, 2024
*** Reason for rollback ***

In the past few days, I have done more research to compare between (1) adding a new parallelism (which is the follow-up work of this cl) and (2) using the existing skyframe FJP. And I am now more inclined to adopt #2.

PiperOrigin-RevId: 610840138
Change-Id: I8caae6641103e5b712bf34f32d02f88415ee23fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants