Modularize manifest python code #384
Merged
+67
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The manifest code used in pkg_tar has uses outside of pkg_tar. Let's modularize it to reduce the number of places it has to be duplicated (it needs to be duplicated in `pkg/private/pkg_files.bzl` to be loaded) into starlark. As a part of this, we create an entry type stringifier for ManifestEntry, and a `collections.namedtuple` representing the fields in the entry. `pkg/private/build_tar.py` was also opportunistically modified to use all of the above.
Interesting how this didn't show up in Linux or macOS...
aiuto
approved these changes
Jul 14, 2021
aiuto
added a commit
to aiuto/rules_pkg
that referenced
this pull request
Jul 15, 2021
aiuto
added a commit
to aiuto/rules_pkg
that referenced
this pull request
Jul 15, 2021
aiuto
added a commit
that referenced
this pull request
Jul 15, 2021
* Initial support for pkg_files* in pkg_zip - This is a mostly minimal PR to switch to the newer style. That is, only plain files and directories. - Followup CLs will add links and tree artifacts. * merge #384
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The manifest code used in pkg_tar has uses outside of pkg_tar. Let's modularize
it to reduce the number of places it has to be duplicated (it needs to be
duplicated in
pkg/private/pkg_files.bzlto be loaded) into starlark.As a part of this, we create an entry type stringifier for ManifestEntry, and a
collections.namedtuplerepresenting the fields in the entry.pkg/private/build_tar.pywas also opportunistically modified to use all of theabove.