Initial support for pkg_files* in pkg_zip #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
aiuto
commented
Jul 7, 2021
aiuto
commented
- This is the minimal PR to switch to the newer style. That is, only plain files.
- Followup CLs will add things previously not supported, such as links.
- Advances pkg_zip supports pkg_filegroup framework #309
- This is a mostly minimal PR to switch to the newer style. That is, only plain files and directories. - Followup CLs will add links and tree artifacts.
nacl
approved these changes
Jul 14, 2021
There was a problem hiding this comment.
You weren't kidding about this size of this. A great start indeed. Comments are meta or minor.
It feels like there should be some more testing here, but this LGTM otherwise. Feel free to submit now if you want to disallow using pkg_* along with normal files in srcs in a later change.
|
Now waiting for #384 |
You should be good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.