Add symlink support to pkg_zip #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nacl
approved these changes
Jan 28, 2022
There was a problem hiding this comment.
LGTM, but I think this needs more testing on Windows, or lack of testing should be documented. I might have some time to look into this next week, but I can't make any guarantees.
See below comments for other ideas, mostly on improvements using the stat module.
symlnks on windows are there own area of fun. Since we are not reading links, what we have should build the same bits on any OS. The question is how they unpack, which is fortunately not our problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add symlink support to pkg_zip. #309
This is, by intent, missing a complete integration test. That is for another quarter #498.