Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg_zip supports pkg_filegroup framework #309

Closed
nacl opened this issue Mar 2, 2021 · 3 comments · Fixed by #537
Closed

pkg_zip supports pkg_filegroup framework #309

nacl opened this issue Mar 2, 2021 · 3 comments · Fixed by #537
Assignees
@aiuto
Labels
P1 An issue that must be resolved. Must have an assignee
Milestone
1.0

Comments

@nacl
Copy link
Collaborator

nacl commented Mar 2, 2021

No description provided.

@nacl nacl added this to the 1.0 milestone Mar 2, 2021
@aiuto aiuto added the P1 An issue that must be resolved. Must have an assignee label Apr 29, 2021
@aiuto aiuto self-assigned this May 7, 2021
@aiuto aiuto mentioned this issue Jul 7, 2021
Merged
@aiuto
Copy link
Collaborator

aiuto commented Jul 28, 2021

Still need support for symlinks

nacl pushed a commit to nacl/rules_pkg that referenced this issue Nov 16, 2021
@rbeasley
[rules_pkg] pkg_zip: initial tree artifact implementation
c76d602 
Notes:
- Rather than tear `_add_manifest_entry` apart, I took the lazy way out
  by constructing dummy `ManifestEntry` objects and recursively calling
  `_add_manifest_entry`.
- vim footers added to build_zip.py and zip_test.py since those srcs
  use 2-space indents.
- I don't know whether I need to file separate issues for the "food
  for thought" code comments or if those could just be tracked in the
  discussion of bazelbuild#309.

Advances bazelbuild#309.

Testing Done: `bazelisk test //tests:zip_test`
Bug Number: VCBAZ-2726
Reviewed by: apsaltis
Review URL: https://reviewboard.eng.vmware.com/r/1842746/
aiuto added a commit to aiuto/rules_pkg that referenced this issue Dec 25, 2021
@aiuto
add symlink support to pkg_zip. bazelbuild#309
50f9c26
@aiuto aiuto mentioned this issue Dec 26, 2021
Merged
aiuto added a commit that referenced this issue Jan 29, 2022
@aiuto
Add symlink support to pkg_zip (#499)
c969557 
* add symlink support to pkg_zip.  #309
* update tests to new mklink attributes
@aiuto
Copy link
Collaborator

aiuto commented Feb 4, 2022

Still need tree_artifact support.

@aiuto aiuto mentioned this issue Feb 4, 2022
Closed
@aiuto aiuto mentioned this issue Feb 12, 2022
Merged
@aiuto
Copy link
Collaborator

aiuto commented Mar 3, 2022

Closed by #537

@aiuto aiuto closed this as completed Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aiuto aiuto

Labels
P1 An issue that must be resolved. Must have an assignee
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Add tree artifact support to pkg_zip aiuto/rules_pkg
2 participants
@nacl @aiuto