fix: make windows ignore pycs in runtime #1715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The downloaded runtimes don't contain pyc files, which means Python tries to create them at runtime, and thus the set of files in the runtime changes. This normally just silently affects cache hits, but on Windows can result is errors. This is because Windows has stricter file access semantics (e.g. a file can't be deleted if its still opened) and the way Python programs are built involves a step to zip everything up (which then requires the pyc to exist to be put into the zip file). To fix, always ignore pyc files for Windows hosts. This should prevent those files from being picked up by the glob and being considered part of the runtime.
aignas
approved these changes
Jan 23, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The downloaded runtimes don't contain pyc files, which means Python tries to create them at runtime, and thus the set of files in the runtime changes. This normally just silently affects cache hits, but on Windows can result is errors. This is because Windows has stricter file access semantics (e.g. a file can't be deleted if its still opened) and the way Python programs are built involves a step to zip everything up (which then requires the pyc to exist to be put into the zip file).
To fix, always ignore pyc files for Windows hosts. This should prevent those files from being picked up by the glob and being considered part of the runtime.