Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make windows ignore pycs in runtime #1715

Merged
merged 2 commits into from
Jan 23, 2024
Merged

fix: make windows ignore pycs in runtime #1715

merged 2 commits into from
Jan 23, 2024

Commits on Jan 23, 2024

  1. fix: make windows ignore pycs in runtime 

    The downloaded runtimes don't contain pyc files, which means Python
tries to create them at runtime, and thus the set of files in the
runtime changes. This normally just silently affects cache hits, but
on Windows can result is errors. This is because Windows has stricter
file access semantics (e.g. a file can't be deleted if its still opened)
and the way Python programs are built involves a step to zip everything
up (which then requires the pyc to exist to be put into the zip file).

To fix, always ignore pyc files for Windows hosts. This should prevent
those files from being picked up by the glob and being considered part
of the runtime.
    @rickeylev
    rickeylev committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    0b0b45b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix.windows.ignore.pyc and fix CHANGELOG

    @aignas
    aignas committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    1ce354a View commit details
    Browse the repository at this point in the history