Add index-while-building support (back) to the Swift build rules #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentleyjones
requested review from
BalestraPatrick,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
brentleyjones
force-pushed
the
bj/add-index-while-building-support-back-to-the-swift-build-rules
branch
from
f9e672b
to
1cda7e5
Compare
When the `swift.index_while_building` feature is set, targets will emit an indexstore directory to the "indexstore" output group. Unlike the original implementation, this one is focused on the remote indexing use case, so we don't support the old behavior meant for local builds of scanning `--swiftcopt` for a manually-specified path that would be the destination for all index data. Users who want to do that should just pass _all_ of the indexing flags to `--swiftcopt` instead of using this feature. PiperOrigin-RevId: 459613898 (cherry picked from commit 8150427) --- Cherry-pick notes: we never removed this. This is mainly just moving things around to make future cherry-picks easier. Though, we did take the `--swiftcopt` change by removing `_is_index_store_path_overridden` (which is a breaking change). Signed-off-by: Brentley Jones <github@brentleyjones.com>
brentleyjones
force-pushed
the
bj/add-index-while-building-support-back-to-the-swift-build-rules
branch
from
1cda7e5
to
26058bc
Compare
thii
approved these changes
Jun 21, 2024
brentleyjones
deleted the
bj/add-index-while-building-support-back-to-the-swift-build-rules
branch
brentleyjones
referenced
this pull request
Jun 21, 2024
When the `swift.index_while_building` feature is set, targets will emit an indexstore directory to the "indexstore" output group. Unlike the original implementation, this one is focused on the remote indexing use case, so we don't support the old behavior meant for local builds of scanning `--swiftcopt` for a manually-specified path that would be the destination for all index data. Users who want to do that should just pass _all_ of the indexing flags to `--swiftcopt` instead of using this feature. PiperOrigin-RevId: 459613898
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
swift.index_while_buildingfeature is set, targets will emit an indexstore directory to the "indexstore" output group.Unlike the original implementation, this one is focused on the remote indexing use case, so we don't support the old behavior meant for local builds of scanning
--swiftcoptfor a manually-specified path that would be the destination for all index data. Users who want to do that should just pass all of the indexing flags to--swiftcoptinstead of using this feature.PiperOrigin-RevId: 459613898
(cherry picked from commit 8150427)
Cherry-pick notes: we never removed this. This is mainly just moving things around to make future cherry-picks easier. Though, we did take the
--swiftcoptchange by removing_is_index_store_path_overridden(which is a breaking change).