Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add index-while-building support (back) to the Swift build rules #1248

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Add index-while-building support (back) to the Swift build rules #1248

merged 1 commit into from
Jun 21, 2024

Commits on Jun 21, 2024

  1. Add index-while-building support (back) to the Swift build rules 

    When the `swift.index_while_building` feature is set, targets will emit an indexstore directory to the "indexstore" output group.

Unlike the original implementation, this one is focused on the remote indexing use case, so we don't support the old behavior meant for local builds of scanning `--swiftcopt` for a manually-specified path that would be the destination for all index data. Users who want to do that should just pass _all_ of the indexing flags to `--swiftcopt` instead of using this feature.

PiperOrigin-RevId: 459613898
(cherry picked from commit 8150427)

---

Cherry-pick notes: we never removed this. This is mainly just moving things around to make future cherry-picks easier. Though, we did take the `--swiftcopt` change by removing `_is_index_store_path_overridden` (which is a breaking change).

Signed-off-by: Brentley Jones <github@brentleyjones.com>
    @allevato @brentleyjones
    allevato authored and brentleyjones committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    26058bc View commit details
    Browse the repository at this point in the history