Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save to .ldr or .mpd #3

Closed
bb1950328 opened this issue Dec 22, 2020 · 0 comments · Fixed by #58
Closed

Save to .ldr or .mpd #3

bb1950328 opened this issue Dec 22, 2020 · 0 comments · Fixed by #58
Assignees
@bb1950328
Labels
💡 new feature A new feature or idea
Milestone
First release

Comments

@bb1950328
Copy link
Owner

Basically the title - add a save functionality so the user can save their work to a file in the LDraw format.

The code needs to go trough the element tree and convert each element back to an ldr string.
if the user opens a file we probably need to save the order of the lines so the order is not changed and the comments are preserved.
@bb1950328 bb1950328 added this to the First release milestone Feb 17, 2021
@bb1950328 bb1950328 added 💡 new feature A new feature or idea and removed new feature labels Feb 26, 2021
@bb1950328 bb1950328 self-assigned this Jul 30, 2021
bb1950328 added a commit that referenced this issue Aug 7, 2021
@bb1950328
#3 add function to save a ldr::File to filesystem
bfb4b0b
bb1950328 added a commit that referenced this issue Aug 8, 2021
@bb1950328
#3 ldr file writer:
2c49b9c 
- do not write trailing zeroes
- fixes for mpd documents (still not all fixed, LDView reports some errors)

fix concurrency issue when rebuilding file list
bb1950328 added a commit that referenced this issue Aug 8, 2021
@bb1950328
#3 ldr file writer:
5fb460c 
- fixed output for mpd files
- small cleanup
t=6.2h
bb1950328 added a commit that referenced this issue Aug 8, 2021
@bb1950328
#3 ldr file writer:
7914c51 
- add functionality to save changes from element tree back to ldr::File (untested)
@bb1950328 bb1950328 mentioned this issue Aug 11, 2021
Merged
bb1950328 added a commit that referenced this issue Aug 12, 2021
@bb1950328
add ability to write to a LDraw file & open multiple documents simult…
c5d6add 
…aneously (#58)

* #3 add function to save a ldr::File to filesystem

* #3 ldr file writer:
- do not write trailing zeroes
- fixes for mpd documents (still not all fixed, LDView reports some errors)

fix concurrency issue when rebuilding file list

* #3 ldr file writer:
- fixed output for mpd files
- small cleanup

* #3 ldr file writer:
- add functionality to save changes from element tree back to ldr::File (untested)

* * refactor part of the controller:: namespace into a Editor class -> now opening multiple files at the same time is supported
* refactor user_actions::Action into an enum
(still things to do until the refactoring is complete, but it runs again)

* revert accidental commit in palanteer submodule

* fix many problems introduced in the Editor refactoring (92cf9b5)

* fix some include errors
log time

* fix some include errors 2

* fix path to string conversion error on windows

* fix second windows build error
t=17h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bb1950328 bb1950328

Labels
💡 new feature A new feature or idea
Projects
None yet
Milestone
First release
Development

Successfully merging a pull request may close this issue.

add ability to write to a LDraw file & open multiple documents simultaneously bb1950328/BrickSim
1 participant
@bb1950328