add ability to write to a LDraw file & open multiple documents simultaneously #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- do not write trailing zeroes - fixes for mpd documents (still not all fixed, LDView reports some errors) fix concurrency issue when rebuilding file list
- fixed output for mpd files - small cleanup t=6.2h
- add functionality to save changes from element tree back to ldr::File (untested)
…now opening multiple files at the same time is supported * refactor user_actions::Action into an enum (still things to do until the refactoring is complete, but it runs again)
log time t=10.5h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #3.
The writing was surprisingly easy. The refactoring of many functionalities that were in the
controller::namespace into aEditorclass was more time-consuming. But now the user can edit multiple files at once.The
user_actions::component was also refactored slightly.Actionis an enum now and there is a callback to check if a certain action is enabled right now.