Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

モノトーンミュージアムのIDを修正 #144

Merged
merged 2 commits into from
Mar 29, 2020
Merged

モノトーンミュージアムのIDを修正 #144

merged 2 commits into from
Mar 29, 2020

Conversation

criticality-psn
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Mar 29, 2020

Codecov Report

Merging #144 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
- Coverage   86.35%   86.32%   -0.03%     
==========================================
  Files         197      197              
  Lines       22249    22164      -85     
==========================================
- Hits        19214    19134      -80     
+ Misses       3035     3030       -5     
Impacted Files Coverage Δ
src/configBcDice.rb 100.00% <ø> (ø)
src/diceBot/DiceBotLoaderList.rb 100.00% <ø> (ø)
src/diceBot/MonotoneMuseum.rb 98.95% <100.00%> (ø)
src/diceBot/MonotoneMuseum_Korean.rb 98.68% <100.00%> (ø)
src/test/testDiceBotLoaders.rb 99.78% <100.00%> (-0.22%) ⬇️
src/diceBot/TokyoGhostResearch.rb 66.66% <0.00%> (-0.73%) ⬇️
src/diceBot/GurpsFW.rb 56.82% <0.00%> (-0.11%) ⬇️
src/diceBot/Insane.rb 78.84% <0.00%> (-0.11%) ⬇️
src/diceBot/Insane_Korean.rb 78.84% <0.00%> (-0.11%) ⬇️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc99a93...a5c54c9. Read the comment docs.

Copy link
Member

@ysakasin ysakasin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ファイル名変更の影響でコードが消えてます。新しい方のファイルを追加してください。

@criticality-psn
Copy link
Contributor Author

ごめんなさい、確認を怠っていました

@ysakasin
Copy link
Member

📝 MonotoneMusium -> MonotoneMuseum

Copy link
Member

@ysakasin ysakasin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます。OKです!

@ysakasin ysakasin merged commit 91a10b7 into bcdice:master Mar 29, 2020
@criticality-psn criticality-psn deleted the monotone_museum_namefix branch March 29, 2020 05:07
ysakasin added a commit that referenced this pull request Aug 30, 2020
モノトーンミュージアムのIDを修正
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants