コード：レイヤードのダイスボットで修正値とクリティカル値に対応 #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysakasin
requested changes
Apr 3, 2020
Co-Authored-By: SAKATA Sinji <ysakasin@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #149 +/- ##
==========================================
- Coverage 86.35% 86.27% -0.08%
==========================================
Files 197 198 +1
Lines 22238 22137 -101
==========================================
- Hits 19203 19099 -104
- Misses 3035 3038 +3
Continue to review full report at Codecov.
|
|
ありがとうございます。修正そのまま反映しました。(GitHubのUI上でSuggestion初使用) ModifierFormatter、他のダイスボットのリファクタリングにも使えそうですね。 |
ysakasin
approved these changes
Apr 3, 2020
Merged
ysakasin
added a commit
that referenced
this pull request
Aug 30, 2020
* コード：レイヤードの修正値に対応 * コード：レイヤードのクリティカル値の変更に対応 * Apply suggestions from code review Co-Authored-By: SAKATA Sinji <ysakasin@gmail.com> Co-authored-by: SAKATA Sinji <ysakasin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
達成地の修正値とクリティカル値の変更(ベイグランツ・ロードの柳生十兵衛等)に対応。
修正値は
nCL+x1@m[c]+x2のx1とx2の2箇所に挿入できます。ダブルクロス等を参考にしましたが、BCDiceをいじるの初めてなので、イマイチわかってない点も多いです。ご指摘ありましたらお願いします。
(SRSからだけ参照されているformat_modifierって使かってよかったのでしょうか・・・？)