Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4515 - Corrections FrameWork #3

Merged
merged 4 commits into from
Aug 26, 2020
Merged

4515 - Corrections FrameWork #3

merged 4 commits into from
Aug 26, 2020

Conversation

cameron-eyds
Copy link
Collaborator

Issue #: /bcgov/entity#4515

Description of changes:

  • Implements an updated application flow for our Corrections and Alterations filings components.

  • A view for Correction and Alteration

  • Updated to use Incorporation Number opposed to logic around NR #'s for app initialization.

  • Updated some error dialogs.

  • Updated the legal api and filing template mixin.

  • Implemented some components in summary view to present the data parsed from the filings, only a temporary representation.

*Note: *

  • Have not updated the unit tests. This will need a significant rework and will most likely be started again from ground up. Using the old tests as reference.

  • A lot of the old / existing components still remain in the repo. Many of which will provide a good foundation for future adaptations.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

@cameron-eyds cameron-eyds self-assigned this Aug 25, 2020
severinbeauvais
severinbeauvais reviewed Aug 25, 2020
View reviewed changes
Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive refactor! :)
Will cleaning up the unit tests (so they pass in GH CI) be part of this ticket?
Approved for now. I trust you to action any comments.

@severinbeauvais
Copy link
Collaborator

For now, maybe disable the broken unit tests?
IMHO, this ticket's scope is too large: Create the framework, yes. Implement a bunch of functionality as well, no -> subsequent ticket.
So I'm happy with what you've done so far... Let's finish this ticket and see what needs doing next.

@cameron-eyds
Copy link
Collaborator Author

For now, maybe disable the broken unit tests?
IMHO, this ticket's scope is too large: Create the framework, yes. Implement a bunch of functionality as well, no -> subsequent ticket.
So I'm happy with what you've done so far... Let's finish this ticket and see what needs doing next.

Awesome, thanks! Sounds like a good plan 👍 Just wrapping up some clean up based on the feedback!

@cameron-eyds
Copy link
Collaborator Author

After 1 review and approval, will merge due to very low impact and risk at this point.

@cameron-eyds cameron-eyds merged commit 311e210 into bcgov:master Aug 26, 2020
seeker25 pushed a commit that referenced this pull request Nov 29, 2023
@Jxio
18728 - COOP Bug: Payment shows up as #3 when it should be #5 (#548)
b39df19 
* fix csr index bug

* 4.7.11
JazzarKarim pushed a commit to JazzarKarim/business-edit-ui that referenced this pull request Jan 26, 2024
@Jxio @JazzarKarim
18728 - COOP Bug: Payment shows up as bcgov#3 when it should be bcgov#5…
804ebf3 
… (bcgov#548)

* fix csr index bug

* 4.7.11
JazzarKarim added a commit that referenced this pull request Jan 26, 2024
@JazzarKarim @seeker25
@dependabot @severinbeauvais @kzdev420 @PaulGarewal @Jxio
19034 rebase legal name branch (#556)
a2c3f8e 
* Add small rendering delay for Firefox, that way the review and confirm scrolls to the top of the screen. (#535)

* 17347 - Add in directors for corrections for CP. (#536)

* Add in directors for corrections for CP.

* Fix unit tests for director change for CP.

* Add in COOP.

* Add in appointmentDate for co-op corrections. (#537)

* Bump postcss from 8.4.30 to 8.4.31 (#533)

Bumps [postcss](https://github.com/postcss/postcss) from 8.4.30 to 8.4.31.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](postcss/postcss@8.4.30...8.4.31)

---
updated-dependencies:
- dependency-name: postcss
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* - app version = 4.7.5 (#541)

- moved director workaround to LegalServices
- moved parties workaround to LegalServices
- removed workaround from Change
- removed workaround from Conversion
- updated unit tests

* - app version = 4.7.6 (#542)

- deleted obsolete "alteration-ui-enabled" FF
- deleted obsolete "change-ui-enabled" FF
- deleted obsolete "conversion-ui-enabled" FF
- removed flag usage from Alteration.vue
- removed flag usage from Change.vue
- removed flag usage from Conversion.vue
- removed flag usage from SpecialResolution.vue

* - app version = 4.7.7 (#543)

- uninstalled v-sanitize
- installed vue-sanitize-directive
- updated imports
- added "basic" option (same as default with old package)

* 17158 update fetchNameRequest (#540)

* 17158 update fetchNameRequest

* add debug code

* add debug --wip

* add debug --wip

* update error handling

* update NR status

* update version

* 18277 - Don't pre select no fee option for co-op correction. (#539)

* Don't pre select no fee option for co-op correction.

* Set to FAS, this way it will display $20.

* Update package version.

* Add in dropdown option for BEN when alterating from ULC (#545)

* add in dropdown option for BEN when going from ULC

* Name request check error update

* Update comment and package versions

* 18716 added phone number and email address to name request correction… (#547)

* 18716 added phone number and email address to name request correction on file and pay

* updated package json

* removed debug code

* 18728 - COOP Bug: Payment shows up as #3 when it should be #5 (#548)

* fix csr index bug

* 4.7.11

* 18735 - Fix rules showing up as being changed, when it's on paper (#549)

* Fix rules being changed, when it's on paper

* Fix bad code

* add in extra || null

* 18622 - Correction - Blank Special Resolution (#550)

* 18495 - Coop Correction Changes when the Resolution is Absent (#551)

* 18495 - Bug Fix - Show Resolution Section when not Correction Filing (#552)

* 19069 - Special Resolution - Validation on blank association type (#553)

* Bump vite from 4.3.9 to 4.5.2 (#555)

Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 4.3.9 to 4.5.2.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v4.5.2/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v4.5.2/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* major package version update

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Travis Semple <travis8814@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Séverin Beauvais <severinbeauvais@users.noreply.github.com>
Co-authored-by: Kevin Zhang <54437031+kzdev420@users.noreply.github.com>
Co-authored-by: Paul <144158015+PaulGarewal@users.noreply.github.com>
Co-authored-by: Jia Xu <Jia.Xu@gov.bc.ca>
JazzarKarim added a commit to JazzarKarim/business-edit-ui that referenced this pull request Jan 31, 2024
@JazzarKarim @seeker25
@dependabot @severinbeauvais @kzdev420 @PaulGarewal @Jxio
19034 rebase legal name branch (bcgov#556)
56c4cc5 
* Add small rendering delay for Firefox, that way the review and confirm scrolls to the top of the screen. (bcgov#535)

* 17347 - Add in directors for corrections for CP. (bcgov#536)

* Add in directors for corrections for CP.

* Fix unit tests for director change for CP.

* Add in COOP.

* Add in appointmentDate for co-op corrections. (bcgov#537)

* Bump postcss from 8.4.30 to 8.4.31 (bcgov#533)

Bumps [postcss](https://github.com/postcss/postcss) from 8.4.30 to 8.4.31.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](postcss/postcss@8.4.30...8.4.31)

---
updated-dependencies:
- dependency-name: postcss
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* - app version = 4.7.5 (bcgov#541)

- moved director workaround to LegalServices
- moved parties workaround to LegalServices
- removed workaround from Change
- removed workaround from Conversion
- updated unit tests

* - app version = 4.7.6 (bcgov#542)

- deleted obsolete "alteration-ui-enabled" FF
- deleted obsolete "change-ui-enabled" FF
- deleted obsolete "conversion-ui-enabled" FF
- removed flag usage from Alteration.vue
- removed flag usage from Change.vue
- removed flag usage from Conversion.vue
- removed flag usage from SpecialResolution.vue

* - app version = 4.7.7 (bcgov#543)

- uninstalled v-sanitize
- installed vue-sanitize-directive
- updated imports
- added "basic" option (same as default with old package)

* 17158 update fetchNameRequest (bcgov#540)

* 17158 update fetchNameRequest

* add debug code

* add debug --wip

* add debug --wip

* update error handling

* update NR status

* update version

* 18277 - Don't pre select no fee option for co-op correction. (bcgov#539)

* Don't pre select no fee option for co-op correction.

* Set to FAS, this way it will display $20.

* Update package version.

* Add in dropdown option for BEN when alterating from ULC (bcgov#545)

* add in dropdown option for BEN when going from ULC

* Name request check error update

* Update comment and package versions

* 18716 added phone number and email address to name request correction… (bcgov#547)

* 18716 added phone number and email address to name request correction on file and pay

* updated package json

* removed debug code

* 18728 - COOP Bug: Payment shows up as bcgov#3 when it should be bcgov#5 (bcgov#548)

* fix csr index bug

* 4.7.11

* 18735 - Fix rules showing up as being changed, when it's on paper (bcgov#549)

* Fix rules being changed, when it's on paper

* Fix bad code

* add in extra || null

* 18622 - Correction - Blank Special Resolution (bcgov#550)

* 18495 - Coop Correction Changes when the Resolution is Absent (bcgov#551)

* 18495 - Bug Fix - Show Resolution Section when not Correction Filing (bcgov#552)

* 19069 - Special Resolution - Validation on blank association type (bcgov#553)

* Bump vite from 4.3.9 to 4.5.2 (bcgov#555)

Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 4.3.9 to 4.5.2.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v4.5.2/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v4.5.2/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* major package version update

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Travis Semple <travis8814@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Séverin Beauvais <severinbeauvais@users.noreply.github.com>
Co-authored-by: Kevin Zhang <54437031+kzdev420@users.noreply.github.com>
Co-authored-by: Paul <144158015+PaulGarewal@users.noreply.github.com>
Co-authored-by: Jia Xu <Jia.Xu@gov.bc.ca>
JazzarKarim added a commit to JazzarKarim/business-edit-ui that referenced this pull request Feb 1, 2024
@JazzarKarim @seeker25
@dependabot @severinbeauvais @kzdev420 @PaulGarewal @Jxio
19034 rebase legal name branch (bcgov#556)
7a07e28 
* Add small rendering delay for Firefox, that way the review and confirm scrolls to the top of the screen. (bcgov#535)

* 17347 - Add in directors for corrections for CP. (bcgov#536)

* Add in directors for corrections for CP.

* Fix unit tests for director change for CP.

* Add in COOP.

* Add in appointmentDate for co-op corrections. (bcgov#537)

* Bump postcss from 8.4.30 to 8.4.31 (bcgov#533)

Bumps [postcss](https://github.com/postcss/postcss) from 8.4.30 to 8.4.31.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](postcss/postcss@8.4.30...8.4.31)

---
updated-dependencies:
- dependency-name: postcss
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* - app version = 4.7.5 (bcgov#541)

- moved director workaround to LegalServices
- moved parties workaround to LegalServices
- removed workaround from Change
- removed workaround from Conversion
- updated unit tests

* - app version = 4.7.6 (bcgov#542)

- deleted obsolete "alteration-ui-enabled" FF
- deleted obsolete "change-ui-enabled" FF
- deleted obsolete "conversion-ui-enabled" FF
- removed flag usage from Alteration.vue
- removed flag usage from Change.vue
- removed flag usage from Conversion.vue
- removed flag usage from SpecialResolution.vue

* - app version = 4.7.7 (bcgov#543)

- uninstalled v-sanitize
- installed vue-sanitize-directive
- updated imports
- added "basic" option (same as default with old package)

* 17158 update fetchNameRequest (bcgov#540)

* 17158 update fetchNameRequest

* add debug code

* add debug --wip

* add debug --wip

* update error handling

* update NR status

* update version

* 18277 - Don't pre select no fee option for co-op correction. (bcgov#539)

* Don't pre select no fee option for co-op correction.

* Set to FAS, this way it will display $20.

* Update package version.

* Add in dropdown option for BEN when alterating from ULC (bcgov#545)

* add in dropdown option for BEN when going from ULC

* Name request check error update

* Update comment and package versions

* 18716 added phone number and email address to name request correction… (bcgov#547)

* 18716 added phone number and email address to name request correction on file and pay

* updated package json

* removed debug code

* 18728 - COOP Bug: Payment shows up as bcgov#3 when it should be bcgov#5 (bcgov#548)

* fix csr index bug

* 4.7.11

* 18735 - Fix rules showing up as being changed, when it's on paper (bcgov#549)

* Fix rules being changed, when it's on paper

* Fix bad code

* add in extra || null

* 18622 - Correction - Blank Special Resolution (bcgov#550)

* 18495 - Coop Correction Changes when the Resolution is Absent (bcgov#551)

* 18495 - Bug Fix - Show Resolution Section when not Correction Filing (bcgov#552)

* 19069 - Special Resolution - Validation on blank association type (bcgov#553)

* Bump vite from 4.3.9 to 4.5.2 (bcgov#555)

Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 4.3.9 to 4.5.2.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v4.5.2/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v4.5.2/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* major package version update

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Travis Semple <travis8814@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Séverin Beauvais <severinbeauvais@users.noreply.github.com>
Co-authored-by: Kevin Zhang <54437031+kzdev420@users.noreply.github.com>
Co-authored-by: Paul <144158015+PaulGarewal@users.noreply.github.com>
Co-authored-by: Jia Xu <Jia.Xu@gov.bc.ca>
JazzarKarim added a commit to JazzarKarim/business-edit-ui that referenced this pull request Feb 22, 2024
@JazzarKarim @seeker25
@dependabot @severinbeauvais @kzdev420 @PaulGarewal @Jxio
19034 rebase legal name branch (bcgov#556)
059956f 
* Add small rendering delay for Firefox, that way the review and confirm scrolls to the top of the screen. (bcgov#535)

* 17347 - Add in directors for corrections for CP. (bcgov#536)

* Add in directors for corrections for CP.

* Fix unit tests for director change for CP.

* Add in COOP.

* Add in appointmentDate for co-op corrections. (bcgov#537)

* Bump postcss from 8.4.30 to 8.4.31 (bcgov#533)

Bumps [postcss](https://github.com/postcss/postcss) from 8.4.30 to 8.4.31.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](postcss/postcss@8.4.30...8.4.31)

---
updated-dependencies:
- dependency-name: postcss
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* - app version = 4.7.5 (bcgov#541)

- moved director workaround to LegalServices
- moved parties workaround to LegalServices
- removed workaround from Change
- removed workaround from Conversion
- updated unit tests

* - app version = 4.7.6 (bcgov#542)

- deleted obsolete "alteration-ui-enabled" FF
- deleted obsolete "change-ui-enabled" FF
- deleted obsolete "conversion-ui-enabled" FF
- removed flag usage from Alteration.vue
- removed flag usage from Change.vue
- removed flag usage from Conversion.vue
- removed flag usage from SpecialResolution.vue

* - app version = 4.7.7 (bcgov#543)

- uninstalled v-sanitize
- installed vue-sanitize-directive
- updated imports
- added "basic" option (same as default with old package)

* 17158 update fetchNameRequest (bcgov#540)

* 17158 update fetchNameRequest

* add debug code

* add debug --wip

* add debug --wip

* update error handling

* update NR status

* update version

* 18277 - Don't pre select no fee option for co-op correction. (bcgov#539)

* Don't pre select no fee option for co-op correction.

* Set to FAS, this way it will display $20.

* Update package version.

* Add in dropdown option for BEN when alterating from ULC (bcgov#545)

* add in dropdown option for BEN when going from ULC

* Name request check error update

* Update comment and package versions

* 18716 added phone number and email address to name request correction… (bcgov#547)

* 18716 added phone number and email address to name request correction on file and pay

* updated package json

* removed debug code

* 18728 - COOP Bug: Payment shows up as bcgov#3 when it should be bcgov#5 (bcgov#548)

* fix csr index bug

* 4.7.11

* 18735 - Fix rules showing up as being changed, when it's on paper (bcgov#549)

* Fix rules being changed, when it's on paper

* Fix bad code

* add in extra || null

* 18622 - Correction - Blank Special Resolution (bcgov#550)

* 18495 - Coop Correction Changes when the Resolution is Absent (bcgov#551)

* 18495 - Bug Fix - Show Resolution Section when not Correction Filing (bcgov#552)

* 19069 - Special Resolution - Validation on blank association type (bcgov#553)

* Bump vite from 4.3.9 to 4.5.2 (bcgov#555)

Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 4.3.9 to 4.5.2.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v4.5.2/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v4.5.2/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* major package version update

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Travis Semple <travis8814@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Séverin Beauvais <severinbeauvais@users.noreply.github.com>
Co-authored-by: Kevin Zhang <54437031+kzdev420@users.noreply.github.com>
Co-authored-by: Paul <144158015+PaulGarewal@users.noreply.github.com>
Co-authored-by: Jia Xu <Jia.Xu@gov.bc.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@severinbeauvais severinbeauvais severinbeauvais approved these changes

Assignees

@cameron-eyds cameron-eyds

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cameron-eyds @severinbeauvais