Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17158 update fetchNameRequest #540

Merged
merged 8 commits into from
Nov 14, 2023

Conversation

kzdev420
Copy link
Collaborator

@kzdev420 kzdev420 commented Nov 7, 2023

Issue #: /bcgov/entity#17158

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

@kzdev420 kzdev420 self-assigned this Nov 7, 2023
@kzdev420 kzdev420 requested a review from JazzarKarim November 7, 2023 14:50
@kzdev420
Copy link
Collaborator Author

kzdev420 commented Nov 7, 2023

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-edit-dev--pr-540-bi05xbsj.web.app

@severinbeauvais
Copy link
Collaborator

Kevin, please add some other reviewers (eg, James, Shaoyun). I will wait for them to review before I approve. Thanks.

Copy link
Collaborator

@JazzarKarim JazzarKarim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Kevin! 👍 Please wait for another approval or two before merging.

@kzdev420
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-edit-dev--pr-540-bi05xbsj.web.app

@kzdev420
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-edit-dev--pr-540-bi05xbsj.web.app

@kzdev420
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-edit-dev--pr-540-bi05xbsj.web.app

@kzdev420
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-edit-dev--pr-540-bi05xbsj.web.app

Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase, resolve my comment, try to get another approval, and then you can merge. Thanks!

@kzdev420
Copy link
Collaborator Author

/gcbrun

Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your app version update was cancelled by the merge. Please update it again :)

@kzdev420
Copy link
Collaborator Author

Your app version update was cancelled by the merge. Please update it again :)

Do you mean to 4.7.7?

@severinbeauvais
Copy link
Collaborator

Your app version update was cancelled by the merge. Please update it again :)

Do you mean to 4.7.7?

Yes, because in main branch it's currently 4.7.6.

@kzdev420
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-edit-dev--pr-540-bi05xbsj.web.app

@kzdev420
Copy link
Collaborator Author

Your app version update was cancelled by the merge. Please update it again :)

Do you mean to 4.7.7?

Yes, because in main branch it's currently 4.7.6.

I updated

@severinbeauvais
Copy link
Collaborator

Looks really good. One more review and then please merge this!

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-edit-dev--pr-540-bi05xbsj.web.app

Copy link

@tshyun24 tshyun24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@severinbeauvais severinbeauvais merged commit a394fd2 into bcgov:main Nov 14, 2023
5 checks passed
Copy link

@jamespaologarcia jamespaologarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JazzarKarim pushed a commit to JazzarKarim/business-edit-ui that referenced this pull request Jan 26, 2024
* 17158 update fetchNameRequest

* add debug code

* add debug --wip

* add debug --wip

* update error handling

* update NR status

* update version
JazzarKarim added a commit that referenced this pull request Jan 26, 2024
* Add small rendering delay for Firefox, that way the review and confirm scrolls to the top of the screen. (#535)

* 17347 - Add in directors for corrections for CP. (#536)

* Add in directors for corrections for CP.

* Fix unit tests for director change for CP.

* Add in COOP.

* Add in appointmentDate for co-op corrections. (#537)

* Bump postcss from 8.4.30 to 8.4.31 (#533)

Bumps [postcss](https://github.com/postcss/postcss) from 8.4.30 to 8.4.31.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](postcss/postcss@8.4.30...8.4.31)

---
updated-dependencies:
- dependency-name: postcss
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* - app version = 4.7.5 (#541)

- moved director workaround to LegalServices
- moved parties workaround to LegalServices
- removed workaround from Change
- removed workaround from Conversion
- updated unit tests

* - app version = 4.7.6 (#542)

- deleted obsolete "alteration-ui-enabled" FF
- deleted obsolete "change-ui-enabled" FF
- deleted obsolete "conversion-ui-enabled" FF
- removed flag usage from Alteration.vue
- removed flag usage from Change.vue
- removed flag usage from Conversion.vue
- removed flag usage from SpecialResolution.vue

* - app version = 4.7.7 (#543)

- uninstalled v-sanitize
- installed vue-sanitize-directive
- updated imports
- added "basic" option (same as default with old package)

* 17158 update fetchNameRequest (#540)

* 17158 update fetchNameRequest

* add debug code

* add debug --wip

* add debug --wip

* update error handling

* update NR status

* update version

* 18277 - Don't pre select no fee option for co-op correction. (#539)

* Don't pre select no fee option for co-op correction.

* Set to FAS, this way it will display $20.

* Update package version.

* Add in dropdown option for BEN when alterating from ULC (#545)

* add in dropdown option for BEN when going from ULC

* Name request check error update

* Update comment and package versions

* 18716 added phone number and email address to name request correction… (#547)

* 18716 added phone number and email address to name request correction on file and pay

* updated package json

* removed debug code

* 18728 - COOP Bug: Payment shows up as #3 when it should be #5 (#548)

* fix csr index bug

* 4.7.11

* 18735 - Fix rules showing up as being changed, when it's on paper (#549)

* Fix rules being changed, when it's on paper

* Fix bad code

* add in extra || null

* 18622 - Correction - Blank Special Resolution (#550)

* 18495 - Coop Correction Changes when the Resolution is Absent (#551)

* 18495 - Bug Fix - Show Resolution Section when not Correction Filing (#552)

* 19069 - Special Resolution - Validation on blank association type (#553)

* Bump vite from 4.3.9 to 4.5.2 (#555)

Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 4.3.9 to 4.5.2.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v4.5.2/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v4.5.2/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* major package version update

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Travis Semple <travis8814@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Séverin Beauvais <severinbeauvais@users.noreply.github.com>
Co-authored-by: Kevin Zhang <54437031+kzdev420@users.noreply.github.com>
Co-authored-by: Paul <144158015+PaulGarewal@users.noreply.github.com>
Co-authored-by: Jia Xu <Jia.Xu@gov.bc.ca>
JazzarKarim added a commit to JazzarKarim/business-edit-ui that referenced this pull request Jan 31, 2024
* Add small rendering delay for Firefox, that way the review and confirm scrolls to the top of the screen. (bcgov#535)

* 17347 - Add in directors for corrections for CP. (bcgov#536)

* Add in directors for corrections for CP.

* Fix unit tests for director change for CP.

* Add in COOP.

* Add in appointmentDate for co-op corrections. (bcgov#537)

* Bump postcss from 8.4.30 to 8.4.31 (bcgov#533)

Bumps [postcss](https://github.com/postcss/postcss) from 8.4.30 to 8.4.31.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](postcss/postcss@8.4.30...8.4.31)

---
updated-dependencies:
- dependency-name: postcss
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* - app version = 4.7.5 (bcgov#541)

- moved director workaround to LegalServices
- moved parties workaround to LegalServices
- removed workaround from Change
- removed workaround from Conversion
- updated unit tests

* - app version = 4.7.6 (bcgov#542)

- deleted obsolete "alteration-ui-enabled" FF
- deleted obsolete "change-ui-enabled" FF
- deleted obsolete "conversion-ui-enabled" FF
- removed flag usage from Alteration.vue
- removed flag usage from Change.vue
- removed flag usage from Conversion.vue
- removed flag usage from SpecialResolution.vue

* - app version = 4.7.7 (bcgov#543)

- uninstalled v-sanitize
- installed vue-sanitize-directive
- updated imports
- added "basic" option (same as default with old package)

* 17158 update fetchNameRequest (bcgov#540)

* 17158 update fetchNameRequest

* add debug code

* add debug --wip

* add debug --wip

* update error handling

* update NR status

* update version

* 18277 - Don't pre select no fee option for co-op correction. (bcgov#539)

* Don't pre select no fee option for co-op correction.

* Set to FAS, this way it will display $20.

* Update package version.

* Add in dropdown option for BEN when alterating from ULC (bcgov#545)

* add in dropdown option for BEN when going from ULC

* Name request check error update

* Update comment and package versions

* 18716 added phone number and email address to name request correction… (bcgov#547)

* 18716 added phone number and email address to name request correction on file and pay

* updated package json

* removed debug code

* 18728 - COOP Bug: Payment shows up as bcgov#3 when it should be bcgov#5 (bcgov#548)

* fix csr index bug

* 4.7.11

* 18735 - Fix rules showing up as being changed, when it's on paper (bcgov#549)

* Fix rules being changed, when it's on paper

* Fix bad code

* add in extra || null

* 18622 - Correction - Blank Special Resolution (bcgov#550)

* 18495 - Coop Correction Changes when the Resolution is Absent (bcgov#551)

* 18495 - Bug Fix - Show Resolution Section when not Correction Filing (bcgov#552)

* 19069 - Special Resolution - Validation on blank association type (bcgov#553)

* Bump vite from 4.3.9 to 4.5.2 (bcgov#555)

Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 4.3.9 to 4.5.2.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v4.5.2/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v4.5.2/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* major package version update

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Travis Semple <travis8814@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Séverin Beauvais <severinbeauvais@users.noreply.github.com>
Co-authored-by: Kevin Zhang <54437031+kzdev420@users.noreply.github.com>
Co-authored-by: Paul <144158015+PaulGarewal@users.noreply.github.com>
Co-authored-by: Jia Xu <Jia.Xu@gov.bc.ca>
JazzarKarim added a commit to JazzarKarim/business-edit-ui that referenced this pull request Feb 1, 2024
* Add small rendering delay for Firefox, that way the review and confirm scrolls to the top of the screen. (bcgov#535)

* 17347 - Add in directors for corrections for CP. (bcgov#536)

* Add in directors for corrections for CP.

* Fix unit tests for director change for CP.

* Add in COOP.

* Add in appointmentDate for co-op corrections. (bcgov#537)

* Bump postcss from 8.4.30 to 8.4.31 (bcgov#533)

Bumps [postcss](https://github.com/postcss/postcss) from 8.4.30 to 8.4.31.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](postcss/postcss@8.4.30...8.4.31)

---
updated-dependencies:
- dependency-name: postcss
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* - app version = 4.7.5 (bcgov#541)

- moved director workaround to LegalServices
- moved parties workaround to LegalServices
- removed workaround from Change
- removed workaround from Conversion
- updated unit tests

* - app version = 4.7.6 (bcgov#542)

- deleted obsolete "alteration-ui-enabled" FF
- deleted obsolete "change-ui-enabled" FF
- deleted obsolete "conversion-ui-enabled" FF
- removed flag usage from Alteration.vue
- removed flag usage from Change.vue
- removed flag usage from Conversion.vue
- removed flag usage from SpecialResolution.vue

* - app version = 4.7.7 (bcgov#543)

- uninstalled v-sanitize
- installed vue-sanitize-directive
- updated imports
- added "basic" option (same as default with old package)

* 17158 update fetchNameRequest (bcgov#540)

* 17158 update fetchNameRequest

* add debug code

* add debug --wip

* add debug --wip

* update error handling

* update NR status

* update version

* 18277 - Don't pre select no fee option for co-op correction. (bcgov#539)

* Don't pre select no fee option for co-op correction.

* Set to FAS, this way it will display $20.

* Update package version.

* Add in dropdown option for BEN when alterating from ULC (bcgov#545)

* add in dropdown option for BEN when going from ULC

* Name request check error update

* Update comment and package versions

* 18716 added phone number and email address to name request correction… (bcgov#547)

* 18716 added phone number and email address to name request correction on file and pay

* updated package json

* removed debug code

* 18728 - COOP Bug: Payment shows up as bcgov#3 when it should be bcgov#5 (bcgov#548)

* fix csr index bug

* 4.7.11

* 18735 - Fix rules showing up as being changed, when it's on paper (bcgov#549)

* Fix rules being changed, when it's on paper

* Fix bad code

* add in extra || null

* 18622 - Correction - Blank Special Resolution (bcgov#550)

* 18495 - Coop Correction Changes when the Resolution is Absent (bcgov#551)

* 18495 - Bug Fix - Show Resolution Section when not Correction Filing (bcgov#552)

* 19069 - Special Resolution - Validation on blank association type (bcgov#553)

* Bump vite from 4.3.9 to 4.5.2 (bcgov#555)

Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 4.3.9 to 4.5.2.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v4.5.2/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v4.5.2/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* major package version update

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Travis Semple <travis8814@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Séverin Beauvais <severinbeauvais@users.noreply.github.com>
Co-authored-by: Kevin Zhang <54437031+kzdev420@users.noreply.github.com>
Co-authored-by: Paul <144158015+PaulGarewal@users.noreply.github.com>
Co-authored-by: Jia Xu <Jia.Xu@gov.bc.ca>
JazzarKarim added a commit to JazzarKarim/business-edit-ui that referenced this pull request Feb 22, 2024
* Add small rendering delay for Firefox, that way the review and confirm scrolls to the top of the screen. (bcgov#535)

* 17347 - Add in directors for corrections for CP. (bcgov#536)

* Add in directors for corrections for CP.

* Fix unit tests for director change for CP.

* Add in COOP.

* Add in appointmentDate for co-op corrections. (bcgov#537)

* Bump postcss from 8.4.30 to 8.4.31 (bcgov#533)

Bumps [postcss](https://github.com/postcss/postcss) from 8.4.30 to 8.4.31.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](postcss/postcss@8.4.30...8.4.31)

---
updated-dependencies:
- dependency-name: postcss
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* - app version = 4.7.5 (bcgov#541)

- moved director workaround to LegalServices
- moved parties workaround to LegalServices
- removed workaround from Change
- removed workaround from Conversion
- updated unit tests

* - app version = 4.7.6 (bcgov#542)

- deleted obsolete "alteration-ui-enabled" FF
- deleted obsolete "change-ui-enabled" FF
- deleted obsolete "conversion-ui-enabled" FF
- removed flag usage from Alteration.vue
- removed flag usage from Change.vue
- removed flag usage from Conversion.vue
- removed flag usage from SpecialResolution.vue

* - app version = 4.7.7 (bcgov#543)

- uninstalled v-sanitize
- installed vue-sanitize-directive
- updated imports
- added "basic" option (same as default with old package)

* 17158 update fetchNameRequest (bcgov#540)

* 17158 update fetchNameRequest

* add debug code

* add debug --wip

* add debug --wip

* update error handling

* update NR status

* update version

* 18277 - Don't pre select no fee option for co-op correction. (bcgov#539)

* Don't pre select no fee option for co-op correction.

* Set to FAS, this way it will display $20.

* Update package version.

* Add in dropdown option for BEN when alterating from ULC (bcgov#545)

* add in dropdown option for BEN when going from ULC

* Name request check error update

* Update comment and package versions

* 18716 added phone number and email address to name request correction… (bcgov#547)

* 18716 added phone number and email address to name request correction on file and pay

* updated package json

* removed debug code

* 18728 - COOP Bug: Payment shows up as bcgov#3 when it should be bcgov#5 (bcgov#548)

* fix csr index bug

* 4.7.11

* 18735 - Fix rules showing up as being changed, when it's on paper (bcgov#549)

* Fix rules being changed, when it's on paper

* Fix bad code

* add in extra || null

* 18622 - Correction - Blank Special Resolution (bcgov#550)

* 18495 - Coop Correction Changes when the Resolution is Absent (bcgov#551)

* 18495 - Bug Fix - Show Resolution Section when not Correction Filing (bcgov#552)

* 19069 - Special Resolution - Validation on blank association type (bcgov#553)

* Bump vite from 4.3.9 to 4.5.2 (bcgov#555)

Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 4.3.9 to 4.5.2.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v4.5.2/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v4.5.2/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* major package version update

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Travis Semple <travis8814@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Séverin Beauvais <severinbeauvais@users.noreply.github.com>
Co-authored-by: Kevin Zhang <54437031+kzdev420@users.noreply.github.com>
Co-authored-by: Paul <144158015+PaulGarewal@users.noreply.github.com>
Co-authored-by: Jia Xu <Jia.Xu@gov.bc.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants