21977 Handling for new bootstrap filing statuses (#684)

* - app version = 7.3.16 - added latestReviewComment property to filing interface - deleted some unused CSS - added pending list toggling from sub-components - added Todo List subtitle for change-requested filings (eg, cont in) - added Todo List default task handling - added Todo List action for change-requests filings (ie, make changes) - added Todo List content (body) for change-requested filings - fixed misc Todo List console log messages - added missing checks for "empty" continuation in - added handling for cont in review fields (submitter, date, comment) - renamed subtitle subcomponents "SubtitleXXX" - added Approved status handling to FilingTemplate.vue - renamed body subcomponents "BodyXXX" - added Rejected status handling to ContinuationIn.vue - added Hide/View Details button to PendingTemplate.vue - updated body in ContinuationIn.vue (pending) - added misc properties to interfaces as needed - updated unit tests * - specifically enable todo list tooltips - specifically enable pending list tooltips - auto-expand Continuation In bootstrap filing - don't show rejected filing details button - added store getter * wip --------- Co-authored-by: Severin Beauvais <severin.beauvais@gov.bc.ca>
bcgov · Jul 23, 2024 · 80576c7 · 80576c7
1 parent 5c5fa2b
commit 80576c7
Show file tree

Hide file tree

Showing 31 changed files with 538 additions and 252 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "business-filings-ui",
-  "version": "7.3.15",
+  "version": "7.3.16",
   "private": true,
   "appName": "Filings UI",
   "sbcName": "SBC Common Components",

diff --git a/src/App.vue b/src/App.vue
@@ -751,7 +751,8 @@ export default class App extends Mixins(
         applicationDate: this.dateToYyyyMmDd(this.apiToDate(header.date)),
         legalFilings: [header.name],
         order: data.courtOrder
-      }
+      },
+      latestReviewComment: header.latestReviewComment
     } as ApiFilingIF
     this.setFilings([filingItem])
   }

diff --git a/src/components/Dashboard/FilingHistoryList.vue b/src/components/Dashboard/FilingHistoryList.vue
@@ -219,19 +219,10 @@ export default class FilingHistoryList extends Mixins(FilingMixin) {
   max-height: 60rem;
 }
 
-.filing-history-item {
-  padding: 1.25rem 1.5rem;
-  pointer-events: none; // disable expansion generally
-}
-
 :deep(.v-expansion-panel-header) {
   min-height: auto !important;
   padding: 0;
   margin-top: 0.25rem;
-
-  .v-expansion-panel-header__icon {
-    display: none;
-  }
 }
 
 // specifically enable anchors, buttons, the pending alert icon and tooltips

diff --git a/src/components/Dashboard/FilingHistoryList/FilingTemplate.vue b/src/components/Dashboard/FilingHistoryList/FilingTemplate.vue
@@ -13,13 +13,13 @@
           </h3>
 
           <slot name="subtitle">
-            <FiledAndPendingPaid
+            <SubtitleFiledAndPendingPaid
               v-if="isStatusPaid"
               class="item-header-subtitle"
               :filing="filing"
               :index="index"
             />
-            <FiledAndPaid
+            <SubtitleFiledAndPaid
               v-else
               class="item-header-subtitle"
               :filing="filing"
@@ -63,7 +63,7 @@
       <slot name="body">
         <!-- is this a generic paid (not yet completed) filing? -->
         <div
-          v-if="isStatusPaid"
+          v-if="isStatusPaid || isStatusApproved"
           class="body-2"
         >
           <h4>Filing Pending</h4>
@@ -137,21 +137,21 @@ import { ApiFilingIF } from '@/interfaces'
 import { EnumUtilities } from '@/services'
 import { FilingNames } from '@bcrs-shared-components/enums'
 import { ContactInfo } from '@/components/common'
+import { useFilingHistoryListStore } from '@/stores'
 import DetailsList from './DetailsList.vue'
 import DocumentsList from './DocumentsList.vue'
-import FiledAndPaid from './subtitles/FiledAndPaid.vue'
-import FiledAndPendingPaid from './subtitles/FiledAndPendingPaid.vue'
 import HeaderActions from './HeaderActions.vue'
-import { useFilingHistoryListStore } from '@/stores'
+import SubtitleFiledAndPaid from './subtitles/SubtitleFiledAndPaid.vue'
+import SubtitleFiledAndPendingPaid from './subtitles/SubtitleFiledAndPendingPaid.vue'
 
 @Component({
   components: {
     ContactInfo,
     DetailsList,
     DocumentsList,
-    FiledAndPaid,
-    FiledAndPendingPaid,
-    HeaderActions
+    HeaderActions,
+    SubtitleFiledAndPaid,
+    SubtitleFiledAndPendingPaid
   }
 })
 export default class FilingTemplate extends Vue {
@@ -165,6 +165,11 @@ export default class FilingTemplate extends Vue {
     return EnumUtilities.isStatusPaid(this.filing)
   }
 
+  /** Whether this filing is in Approved status. */
+  get isStatusApproved (): boolean {
+    return EnumUtilities.isStatusApproved(this.filing)
+  }
+
   /** The title of this filing. */
   get title (): string {
     if (EnumUtilities.isTypeAlteration(this.filing)) return FilingNames.ALTERATION

diff --git a/...ingHistoryList/bodies/FutureEffective.vue → ...istoryList/bodies/BodyFutureEffective.vue b/...ingHistoryList/bodies/FutureEffective.vue → ...istoryList/bodies/BodyFutureEffective.vue
@@ -1,5 +1,5 @@
 <template>
-  <div class="future-effective body-2">
+  <div class="future-effective-body body-2">
     <h4>{{ _.subtitle }}</h4>
 
     <p>
@@ -41,7 +41,7 @@ import { useBusinessStore } from '@/stores'
 @Component({
   components: { ContactInfo }
 })
-export default class FutureEffective extends Vue {
+export default class BodyFutureEffective extends Vue {
   @Getter(useBusinessStore) getLegalName!: string
 
   /** The subject filing. */

diff --git a/...oryList/bodies/FutureEffectivePending.vue → ...ist/bodies/BodyFutureEffectivePending.vue b/...oryList/bodies/FutureEffectivePending.vue → ...ist/bodies/BodyFutureEffectivePending.vue
@@ -1,5 +1,5 @@
 <template>
-  <div class="future-effective-pending body-2">
+  <div class="body-future-effective-pending body-2">
     <h4>{{ _.subtitle }}</h4>
 
     <p>
@@ -35,7 +35,7 @@ import { useBusinessStore } from '@/stores'
 @Component({
   components: { ContactInfo }
 })
-export default class FutureEffectivePending extends Vue {
+export default class BodyFutureEffectivePending extends Vue {
   @Getter(useBusinessStore) getLegalName!: string
 
   /** The subject filing. */

diff --git a/src/components/Dashboard/FilingHistoryList/filings/AlterationFiling.vue b/src/components/Dashboard/FilingHistoryList/filings/AlterationFiling.vue
@@ -5,14 +5,14 @@
     :index="index"
   >
     <template #subtitle>
-      <FiledAndPendingPaid
+      <SubtitleFiledAndPendingPaid
         v-if="isFutureEffectivePending"
         class="item-header-subtitle"
         :filing="filing"
         :index="index"
       />
 
-      <FutureEffectivePaid
+      <SubtitleFutureEffectivePaid
         v-else-if="isFutureEffective"
         class="item-header-subtitle"
         :filing="filing"
@@ -21,12 +21,12 @@
     </template>
 
     <template #body>
-      <FutureEffectivePending
+      <BodyFutureEffectivePending
         v-if="isFutureEffectivePending"
         :filing="filing"
       />
 
-      <FutureEffective
+      <BodyFutureEffective
         v-else-if="isFutureEffective"
         :filing="filing"
       />
@@ -63,21 +63,21 @@ import { CorpTypeCd, GetCorpFullDescription } from '@bcrs-shared-components/corp
 import { DateTooltip } from '@/components/common'
 import { ApiFilingIF } from '@/interfaces'
 import { DateUtilities, EnumUtilities } from '@/services'
-import FiledAndPendingPaid from '../subtitles/FiledAndPendingPaid.vue'
+import SubtitleFiledAndPendingPaid from '../subtitles/SubtitleFiledAndPendingPaid.vue'
 import FilingTemplate from '../FilingTemplate.vue'
-import FutureEffective from '../bodies/FutureEffective.vue'
-import FutureEffectivePaid from '../subtitles/FutureEffectivePaid.vue'
-import FutureEffectivePending from '../bodies/FutureEffectivePending.vue'
+import BodyFutureEffective from '../bodies/BodyFutureEffective.vue'
+import SubtitleFutureEffectivePaid from '../subtitles/SubtitleFutureEffectivePaid.vue'
+import BodyFutureEffectivePending from '../bodies/BodyFutureEffectivePending.vue'
 import { useBusinessStore } from '@/stores'
 
 @Component({
   components: {
+    BodyFutureEffective,
+    BodyFutureEffectivePending,
     DateTooltip,
-    FiledAndPendingPaid,
     FilingTemplate,
-    FutureEffective,
-    FutureEffectivePaid,
-    FutureEffectivePending
+    SubtitleFiledAndPendingPaid,
+    SubtitleFutureEffectivePaid
   }
 })
 export default class AlterationFiling extends Vue {

diff --git a/src/components/Dashboard/FilingHistoryList/filings/AmalgamationFiling.vue b/src/components/Dashboard/FilingHistoryList/filings/AmalgamationFiling.vue
@@ -5,14 +5,14 @@
     :index="index"
   >
     <template #subtitle>
-      <FiledAndPendingPaid
+      <SubtitleFiledAndPendingPaid
         v-if="isFutureEffectivePending"
         class="item-header-subtitle"
         :filing="filing"
         :index="index"
       />
 
-      <FutureEffectivePaid
+      <SubtitleFutureEffectivePaid
         v-else-if="isFutureEffective"
         class="item-header-subtitle"
         :filing="filing"
@@ -21,12 +21,12 @@
     </template>
 
     <template #body>
-      <FutureEffectivePending
+      <BodyFutureEffectivePending
         v-if="isFutureEffectivePending"
         :filing="filing"
       />
 
-      <FutureEffective
+      <BodyFutureEffective
         v-else-if="isFutureEffective"
         :filing="filing"
       />
@@ -63,20 +63,20 @@ import { Component, Prop, Vue } from 'vue-property-decorator'
 import { Getter } from 'pinia-class'
 import { ApiFilingIF } from '@/interfaces'
 import { DateUtilities, EnumUtilities } from '@/services'
-import FiledAndPendingPaid from '../subtitles/FiledAndPendingPaid.vue'
+import SubtitleFiledAndPendingPaid from '../subtitles/SubtitleFiledAndPendingPaid.vue'
 import FilingTemplate from '../FilingTemplate.vue'
-import FutureEffective from '../bodies/FutureEffective.vue'
-import FutureEffectivePaid from '../subtitles/FutureEffectivePaid.vue'
-import FutureEffectivePending from '../bodies/FutureEffectivePending.vue'
+import BodyFutureEffective from '../bodies/BodyFutureEffective.vue'
+import SubtitleFutureEffectivePaid from '../subtitles/SubtitleFutureEffectivePaid.vue'
+import BodyFutureEffectivePending from '../bodies/BodyFutureEffectivePending.vue'
 import { useBusinessStore, useConfigurationStore } from '@/stores'
 
 @Component({
   components: {
-    FiledAndPendingPaid,
+    BodyFutureEffective,
+    BodyFutureEffectivePending,
     FilingTemplate,
-    FutureEffective,
-    FutureEffectivePaid,
-    FutureEffectivePending
+    SubtitleFiledAndPendingPaid,
+    SubtitleFutureEffectivePaid
   }
 })
 export default class AmalgamationFiling extends Vue {

diff --git a/src/components/Dashboard/FilingHistoryList/filings/ChangeOfAddress.vue b/src/components/Dashboard/FilingHistoryList/filings/ChangeOfAddress.vue
@@ -5,7 +5,7 @@
     :index="index"
   >
     <template #subtitle>
-      <CoaFiledAndPending
+      <SubtitleCoaFiledAndPending
         v-if="isFutureEffective"
         class="item-header-subtitle"
         :filing="filing"
@@ -26,14 +26,14 @@ import { Component, Prop, Vue } from 'vue-property-decorator'
 import { Getter } from 'pinia-class'
 import { ApiFilingIF } from '@/interfaces'
 import { DateUtilities, EnumUtilities } from '@/services'
-import CoaFiledAndPending from '../subtitles/CoaFiledAndPending.vue'
+import SubtitleCoaFiledAndPending from '../subtitles/SubtitleCoaFiledAndPending.vue'
 import FilingTemplate from '../FilingTemplate.vue'
 import { useBusinessStore } from '@/stores'
 
 @Component({
   components: {
-    CoaFiledAndPending,
-    FilingTemplate
+    FilingTemplate,
+    SubtitleCoaFiledAndPending
   }
 })
 export default class ChangeOfAddress extends Vue {