21977 Handling for new bootstrap filing statuses #684
Conversation
| @@ -751,7 +751,8 @@ export default class App extends Mixins( | |||
| applicationDate: this.dateToYyyyMmDd(this.apiToDate(header.date)), | |||
| legalFilings: [header.name], | |||
| order: data.courtOrder | |||
| } | |||
| }, | |||
| latestReviewComment: header.latestReviewComment | |||
There was a problem hiding this comment.
New property from API that we need for the filing body in case the application is rejected, ie:
|
|
||
| .v-expansion-panel-header__icon { | ||
| display: none; | ||
| } |
There was a problem hiding this comment.
Obsolete CSS.
| @@ -63,7 +63,7 @@ | |||
| <slot name="body"> | |||
| <!-- is this a generic paid (not yet completed) filing? --> | |||
| <div | |||
| v-if="isStatusPaid" | |||
| v-if="isStatusPaid || isStatusApproved" | |||
There was a problem hiding this comment.
Approved looks like Paid.
(Rejected is handled in ContinuationIn component, not here in the template.)
| letter-spacing: -0.01rem; | ||
| font-size: $px-14; | ||
| font-weight: 700; | ||
| } |
There was a problem hiding this comment.
Obsolete CSS.
| <span>CHANGE REQUESTED</span> | ||
| <span class="vert-pipe" /> | ||
| <span>PAID (filed by {{ item.submitter }} on <DateTooltip :date="item.submittedDate" />)</span> | ||
| </div> |
There was a problem hiding this comment.
There's only 1 type of filing that can be "change requested" right now, but I wrote this generically in case we get others.
| <!-- non-staff see no buttons for staff filings (cont out, conversion, correction, restoration) --> | ||
| <template v-else-if="!isRoleStaff && isStaffFiling(item)"> | ||
| <!-- no action button in this case --> | ||
| </template> |
There was a problem hiding this comment.
I moved this up because it takes precedence over a new annual report.
| @@ -532,10 +560,7 @@ | |||
|
|
|||
| <!-- is this a draft correction? --> | |||
| <template v-else-if="EnumUtilities.isStatusDraft(item) && EnumUtilities.isTypeCorrection(item)"> | |||
| <div | |||
| data-test-class="correction-draft" | |||
There was a problem hiding this comment.
We aren't doing anything with the data-test-class so I removed the last two (this and below).
| @@ -1147,8 +1190,7 @@ export default class TodoList extends Mixins(AllowableActionsMixin, DateMixin) { | |||
| await this.loadSpecialResolution(task) | |||
| break | |||
| default: | |||
| // eslint-disable-next-line no-console | |||
| console.log('ERROR - invalid name in filing header =', header) | |||
| await this.loadDefaultTask(task) | |||
There was a problem hiding this comment.
There are some tasks that appear in the Todo List and that we don't handle. This new code will actually display them, making it clear to Ops what needs to be fixed (ie, unblock task in Todo List).
| nameRequest: this.getNameRequest, | ||
| submitter: header.submitter, | ||
| submittedDate: new Date(header.date), // API format | ||
| latestReviewComment: header?.latestReviewComment |
There was a problem hiding this comment.
New properties needed in case changes are needed, ie:
| @@ -1279,17 +1279,18 @@ describe('Filing History List - incorporation applications', () => { | |||
| submitter: 'Cameron' | |||
| } as any | |||
| ]) | |||
| filingHistoryListStore.setPanel(null) // so we can re-open it | |||
There was a problem hiding this comment.
A panel (in the store) was left open from a previous test.
|
/gcbrun |
|
Temporary Url for review: https://business-filings-dev--pr-684-83ygv5ha.web.app SB says, try these:
|
| This {{ filing.displayName }} is rejected for the following reasons: | ||
| </p> | ||
| <p> | ||
| {{ filing.latestReviewComment || '[staff rejection message]' }} |
There was a problem hiding this comment.
do we not need to show the lastReviewComment when change requested?
There was a problem hiding this comment.
Yes, we do. It's in the Todo List -- see line 613.
- added latestReviewComment property to filing interface - deleted some unused CSS - added pending list toggling from sub-components - added Todo List subtitle for change-requested filings (eg, cont in) - added Todo List default task handling - added Todo List action for change-requests filings (ie, make changes) - added Todo List content (body) for change-requested filings - fixed misc Todo List console log messages - added missing checks for "empty" continuation in - added handling for cont in review fields (submitter, date, comment) - renamed subtitle subcomponents "SubtitleXXX" - added Approved status handling to FilingTemplate.vue - renamed body subcomponents "BodyXXX" - added Rejected status handling to ContinuationIn.vue - added Hide/View Details button to PendingTemplate.vue - updated body in ContinuationIn.vue (pending) - added misc properties to interfaces as needed - updated unit tests
|
/gcbrun |
|
Temporary Url for review: https://business-filings-dev--pr-684-83ygv5ha.web.app |
- specifically enable pending list tooltips - auto-expand Continuation In bootstrap filing - don't show rejected filing details button - added store getter
| // expand bootstrap filing by default | ||
| // assumes this the only filing in the Filing History list (which it should be) | ||
| this.setPanel(0) | ||
| } |
There was a problem hiding this comment.
I'm thinking we could do this for the other bootstrap filings (amalgamations, incorporations and registrations). Thoughts? Maybe next time I'm in this area of code.
|
Issue #: bcgov/entity#21977
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).