Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

21977 Got rid of Enum Mixin #681

Merged
merged 2 commits into from
Jul 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "business-filings-ui",
"version": "7.3.11",
"version": "7.3.12",
"private": true,
"appName": "Filings UI",
"sbcName": "SBC Common Components",
Expand Down
18 changes: 10 additions & 8 deletions src/App.vue
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ import {
getRegistryDashboardBreadcrumb,
getStaffDashboardBreadcrumb
} from '@/resources'
import { CommonMixin, DateMixin, DirectorMixin, EnumMixin, FilingMixin, NameRequestMixin } from '@/mixins'
import { CommonMixin, DateMixin, DirectorMixin, FilingMixin, NameRequestMixin } from '@/mixins'
import { AuthServices, EnumUtilities, LegalServices } from '@/services/'
import {
ApiFilingIF,
Expand Down Expand Up @@ -195,7 +195,6 @@ export default class App extends Mixins(
CommonMixin,
DateMixin,
DirectorMixin,
EnumMixin,
FilingMixin,
NameRequestMixin
) {
Expand Down Expand Up @@ -468,7 +467,7 @@ export default class App extends Mixins(
}
}

// is this a bootstrap business? (eg, incorporation/registration/amalgamation)
// is this a bootstrap filing? (eg, incorporation/registration/amalgamation/continuation)
if (this.tempRegNumber) {
try {
this.nameRequestInvalidType = null // reset for new fetches
Expand Down Expand Up @@ -509,7 +508,7 @@ export default class App extends Mixins(
this.storeTasks(data[2])
this.storeParties(data[4])

// now that we have business info, load state filing
// now that we have business info, load the state filing (if there is one)
await this.loadStateFiling()

// now that we know entity type, store config object
Expand Down Expand Up @@ -610,7 +609,10 @@ export default class App extends Mixins(
}
}

/** Verifies and stores a bootstrap business' data. */
/**
* Verifies and stores a bootstrap filing's data to make this UI (entity dashboard)
* look like a business.
*/
storeBootstrapBusinessData (response: any): void {
const filing = response?.filing
const filingName = filing.header?.name as FilingTypes
Expand Down Expand Up @@ -639,7 +641,7 @@ export default class App extends Mixins(
else if (isContinuationInApplication) entityStatus = EntityStatus.DRAFT_CONTINUATION_IN
else if (isIncorporationApplication) entityStatus = EntityStatus.DRAFT_INCORP_APP
else if (isRegistration) entityStatus = EntityStatus.DRAFT_REGISTRATION
else throw new Error(`Invalid ${filingName} filing - filing name`)
else throw new Error(`Invalid status ${status} for ${filingName} filing`)
break

case FilingStatus.APPROVED:
Expand All @@ -652,11 +654,11 @@ export default class App extends Mixins(
else if (isContinuationInApplication) entityStatus = EntityStatus.FILED_CONTINUATION_IN
else if (isIncorporationApplication) entityStatus = EntityStatus.FILED_INCORP_APP
else if (isRegistration) entityStatus = EntityStatus.FILED_REGISTRATION
else throw new Error(`Invalid ${filingName} filing - filing name`)
else throw new Error(`Invalid status ${status} for ${filingName} filing`)
break

default:
throw new Error(`Invalid ${filingName} filing - filing status = ${status}`)
throw new Error(`Invalid status ${status} for ${filingName} filing`)
}

// special check for amalgamation application
Expand Down
Loading
Loading