21977 Got rid of Enum Mixin #681
Conversation
- replaced all calls to Enum Mixin methods by calls to Enum Utilities class - deleted enum-mixin.ts - added initial PendingList.vue (WIP but disabled) - replaced some getEntityStatus with store isXXX helpers
There was a problem hiding this comment.
This new component isn't being used yet. Right now it's basically a copy of TodoList.vue. I recommend you don't bother reviewing this component as it will change significantly. I'm working on its data architecture presently. I hope this component will be "simple" like FilingHistoryList instead of really complex like TodoList.
src/mixins/enum-mixin.ts
Outdated
There was a problem hiding this comment.
In some cases, mixins can be very practical, but they "pollute" the component namespace (ie, all their methods are attached to this). This hasn't been a problem (due to long naming) but it's usually not a good practise.
Something I thought was a problem was not being able to (easily) find the definitions/declarations for mixin methods. By now having them in the EnumUtilities class, it's obvious where they are and you can F12 to them.
We started deprecating this mixin in early 2023 but did not finish getting rid of it. I'm getting rid of it now because I'm going to restructure a few things (states and getters).
| @@ -96,6 +96,46 @@ export default class EnumUtilities { | |||
| return (item.name === FilingTypes.AGM_LOCATION_CHANGE) | |||
| } | |||
|
|
|||
| /** Returns True if filing is an Amalgamation Application. */ | |||
There was a problem hiding this comment.
These were simply moved up from below so the methods are (mostly) in alphabetized.
| @@ -44,6 +44,23 @@ | |||
| /> | |||
| </section> | |||
|
|
|||
| <!-- Pending section--> | |||
| <section | |||
| v-if="false" | |||
There was a problem hiding this comment.
New section, in progress in the subject ticket, not displayed at the moment.
| @@ -83,6 +83,7 @@ describe('Dashboard - UI', () => { | |||
| expect(wrapper.findComponent(DirectorListSm).exists()).toBe(true) | |||
| }) | |||
|
|
|||
| // *** TODO: add tests for Pending status | |||
There was a problem hiding this comment.
I will be doing this in the subject ticket, in future commits.
- renamed businessStore::setStateFiling() -> setStateFilingUrl() to reduce confusion with rootStore::setStateFiling()
|
/gcbrun |
That's OK. I wanted to merge this asap so others could build upon it if needed (and so I could rebase and keep each PR concise). |
Issue #: bcgov/entity#21977
This is a cleanup activity for the subject ticket. This change should not affect functionality at all.
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).