21977 Implemented Pending list #683
Conversation
- now store pending bootstrap item to Pendings list - added "pendings" store state, action, getter - added pending conditionals to dashboard v-cards - refactored PendingList.vue - implemented PendingTemplate.vue - implemented ContinuationIn.vue - misc cleanup
| this.storeAddresses({ data: data.offices || [] }) | ||
|
|
||
| // set parties | ||
| this.storeParties({ data: { parties: data.parties || [] } }) |
There was a problem hiding this comment.
Although this bootstrap filing isn't complete, we want to show the addresses and parties (both disabled) on the page, ie:
| notify you of the results by email. You can also come back here to check on the progress. | ||
| </p> | ||
| </div> | ||
| </template> |
There was a problem hiding this comment.
This filing only needs to override the default (empty) body.
| @@ -69,7 +69,7 @@ | |||
| :class="{'invalid-section ml-n1 pl-1 rounded-0': showInvalidSection(item)}" | |||
| > | |||
| <div class="list-item"> | |||
| <div class="todo-label"> | |||
| <div class="todo-label pt-1"> | |||
There was a problem hiding this comment.
This (and line 2307) is a very subtle change but it better aligns the View Details button and the Continue In button.
Before:
After:
| } | ||
| if (this.isContinuationInTodo) return this.getTasks[0]?.task.filing.displayName | ||
| if (this.isContinuationInPending) return this.getPendingsList[0].displayName | ||
| if (this.isContinuationInFiling) return this.getFilings[0]?.displayName |
There was a problem hiding this comment.
^^ get Display Name from correct list
Example when filing is in Pending list:
| @@ -49,6 +49,8 @@ export interface RootStateIF { | |||
| parties: Array<PartyIF> | |||
| recordsAddress: OfficeAddressIF | |||
| registeredAddress: OfficeAddressIF | |||
| tasks: Array<ApiTaskIF> // "tasks" data from API | |||
| // *** TODO: declare a type for pendingsList | |||
| pendingsList: Array<any> // pendings list from bootstrap filing | |||
There was a problem hiding this comment.
I'll declare a type for this in my next PR as I keep working on the ticket.
| Vue.use(Vuetify) | ||
| const vuetify = new Vuetify({}) | ||
|
|
||
| // *** TODO: implement this |
There was a problem hiding this comment.
I'll do this in my next PR as I keep working on the ticket.
There was a problem hiding this comment.
Left side is code taken from TodoList.vue. Right side is modeled after FilingHistoryList.vue. Way cleaner!
(To be transparent, different sub-components/files handle the decoding and display of each filing type.)
There was a problem hiding this comment.
This is the template for pending items.
Actual items (eg, ContinuationIn.vue, below) use this template and can override any of the slots.
There was a problem hiding this comment.
Here's a default (fallback) filing that uses the template and doesn't override any slots.
|
/gcbrun |
|
Temporary Url for review: https://business-filings-dev--pr-683-s9ucczd2.web.app SB says, try these:
|
* - app version = 7.3.14 - now store pending bootstrap item to Pendings list - added "pendings" store state, action, getter - added pending conditionals to dashboard v-cards - refactored PendingList.vue - implemented PendingTemplate.vue - implemented ContinuationIn.vue - misc cleanup * - renamed setPendings -> setPendingsList * - added DefaultFiling.vue * - renamed pendings -> pendingsList --------- Co-authored-by: Severin Beauvais <severin.beauvais@gov.bc.ca> WIP - removed some unused CSS
Issue #: bcgov/entity#21977
This is another incremental code change for the subject ticket.
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).