Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filings UI: display continuation in filing in intermediate states (entity dashboard) #21977

Closed
7 of 8 tasks
severinbeauvais opened this issue Jun 24, 2024 · 14 comments
Closed
7 of 8 tasks
Assignees
Labels
Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. UX Assurance

Comments

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Jun 24, 2024

Figma: https://www.figma.com/design/wVF8EcUCUR20YyqA0wHVJp/Continuation-In-V5?node-id=2154-3491&t=YoHJyOAzkMWjeTJ4-0

A continuation in filing is a bootstrap filing, so there is no business id -- a temporary business number is used. In this special mode, Filings UI fetches the bootstrap filing using the filing endpoint and then determines, based on the filing status, whether it belongs in the Todo List or the Filing History List.

Filings UI needs to be updated to display a continuation in filing in different states:

  1. DRAFT
    • same as today
    • in Todo List
    • can be empty draft or resumable draft
    • can be resumed or deleted
  2. AWAITING_REVIEW (Pending Staff Review)
    • in Pending List
    • no outputs
    • what does Future Effective look like?
      • needs to say "Future Effective"
  3. CHANGE_REQUESTED
    • in Todo List
    • action button should be "Make Changes"
    • no delete action
  4. APPROVED
    • in Filing History List
    • same as today (pending / future-effecive)
    • see Figma for FE blurb
  5. REJECTED
    • in Filing History List
    • show application
    • show receipt
  6. COMPLETED
    • same as today
    • in Filing History List
    • can be using T number or new business ID

To do:

@severinbeauvais severinbeauvais added the Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. label Jun 24, 2024
@severinbeauvais severinbeauvais changed the title Filings UI: display filing in correct list Filings UI: display continuation in filing in intermediate states Jun 24, 2024
@severinbeauvais severinbeauvais changed the title Filings UI: display continuation in filing in intermediate states Filings UI: display continuation in filing in intermediate states (entity dashboard) Jun 26, 2024
@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Jun 27, 2024

deleted obsolete comment

@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Jul 4, 2024

deleted obsolete comment

1 similar comment
@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Jul 5, 2024

deleted obsolete comment

@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Jul 19, 2024

Test Notes

Invalid Application

Prior to this ticket, bootstrap filings in "awaiting review" (or change-requested or approved or rejected) state would not load in Filings UI -- an "invalid application" dialog would display.

Now, Filings UI handles all possible bootstrap filing statuses (per description above).

You can create your own bootstrap filings (and update their state in the database, because some of the processing isn't in place yet), or you can refer to my screenshots below.

Default Task

In this ticket, I also implemented handling for a "default task" in the Todo List -- that's a task that isn't handled normally, such as a staff filing (which cannot usually be in the Todo List except if there's a pay error, which should never happen but sometimes does).

Before this change, the task was not displayed in the Todo List and all actions were disallowed, which was very puzzling. (The dev console said, "ERROR - invalid name in filing header".)

Now, the task displays in the Todo List but with no actions. (Resolving this situation requires Ops intervention.)

Sample business: https://dev.business.bcregistry.gov.bc.ca/C9900724

Screenshot:

image.png

@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Jul 19, 2024

Sample Screenshots

New continuation application (empty draft):
image.png

Draft continuation application (contains some user data):
image.png

Pending staff review:
image.png

Pending staff review + future-effective:
image.png

Change requested:
image.png

Approved:
image.png

Approved + future-effective:
image.png

Rejected:
image.png

Completed (as bootstrap business):
image.png

Completed (as new business):
image.png

Note that some of the states above don't yet show the latest staff comment (review result) or the correct set of documents. This is all API work. The UI should work correctly when the API work is done.

@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Jul 23, 2024

Sample bootstrap filings (as used for the demo on July 23)

DRAFT: https://dev.business.bcregistry.gov.bc.ca/T41r8eG6OQ
AWAITING REVIEW: https://dev.business.bcregistry.gov.bc.ca/TmxEXv5iAW
CHANGE REQUESTED: https://dev.business.bcregistry.gov.bc.ca/T1nUSllvEt
REJECTED: https://dev.business.bcregistry.gov.bc.ca/T0uCJs8voi
COMPLETED: https://dev.business.bcregistry.gov.bc.ca/TNm792OzNs

(APPROVED is a transient state that starts when staff approve the review and ends when the Filer completes the application. It is equivalent to PENDING. It is usually very fast/temporary so it's hard to demo.)

@andyyanggov
Copy link
Collaborator

For the REJECTED state, have we decided not to show any outputs? @NaveenHebbale

@severinbeauvais
Copy link
Collaborator Author

For the rejected state, we will show the the application output and, if it shows the refund, the receipt. (The receipt may show both the payment and the refund. Naveen to verify.)

We still have tickets #22371 and #22443 to implement the rejected state documents.

@NaveenHebbale
Copy link

@severinbeauvais @andyyanggov, During Rejection state: Can you show the application only? Receipt _ I checked in NameX - Refund doesn't generate refund receipts.
image.png

@severinbeauvais
Copy link
Collaborator Author

Naveen, do you have a screenshot of the receipt PDF?

Also, the control of whether to show the receipt or not is ticket 22371. Please move this requirement to that ticket.

@NaveenHebbale
Copy link

@severinbeauvais
Snapshot pdf receipt
image.png

@andyyanggov
Copy link
Collaborator

We still have tickets #22371 and #22443 to implement the rejected state documents.

Sounds good.

@severinbeauvais
Copy link
Collaborator Author

Naveen, thanks for the receipt screenshot. Darn, I wonder where that rumour came from that the refund was on the receipt. Do you think we should look into that a bit more?

@NaveenHebbale
Copy link

implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. UX Assurance
Projects
None yet
Development

No branches or pull requests

3 participants