-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filings UI: display continuation in filing in intermediate states (entity dashboard) #21977
Comments
deleted obsolete comment |
deleted obsolete comment |
1 similar comment
deleted obsolete comment |
Test NotesInvalid ApplicationPrior to this ticket, bootstrap filings in "awaiting review" (or change-requested or approved or rejected) state would not load in Filings UI -- an "invalid application" dialog would display. Now, Filings UI handles all possible bootstrap filing statuses (per description above). You can create your own bootstrap filings (and update their state in the database, because some of the processing isn't in place yet), or you can refer to my screenshots below. Default TaskIn this ticket, I also implemented handling for a "default task" in the Todo List -- that's a task that isn't handled normally, such as a staff filing (which cannot usually be in the Todo List except if there's a pay error, which should never happen but sometimes does). Before this change, the task was not displayed in the Todo List and all actions were disallowed, which was very puzzling. (The dev console said, "ERROR - invalid name in filing header".) Now, the task displays in the Todo List but with no actions. (Resolving this situation requires Ops intervention.) Sample business: https://dev.business.bcregistry.gov.bc.ca/C9900724 Screenshot: |
Sample bootstrap filings (as used for the demo on July 23)DRAFT: https://dev.business.bcregistry.gov.bc.ca/T41r8eG6OQ (APPROVED is a transient state that starts when staff approve the review and ends when the Filer completes the application. It is equivalent to PENDING. It is usually very fast/temporary so it's hard to demo.) |
For the REJECTED state, have we decided not to show any outputs? @NaveenHebbale |
@severinbeauvais @andyyanggov, During Rejection state: Can you show the application only? Receipt _ I checked in NameX - Refund doesn't generate refund receipts. |
Naveen, do you have a screenshot of the receipt PDF? Also, the control of whether to show the receipt or not is ticket 22371. Please move this requirement to that ticket. |
@severinbeauvais |
Naveen, thanks for the receipt screenshot. Darn, I wonder where that rumour came from that the refund was on the receipt. Do you think we should look into that a bit more? |
implemented |
Figma: https://www.figma.com/design/wVF8EcUCUR20YyqA0wHVJp/Continuation-In-V5?node-id=2154-3491&t=YoHJyOAzkMWjeTJ4-0
A continuation in filing is a bootstrap filing, so there is no business id -- a temporary business number is used. In this special mode, Filings UI fetches the bootstrap filing using the
filing
endpoint and then determines, based on the filing status, whether it belongs in the Todo List or the Filing History List.Filings UI needs to be updated to display a continuation in filing in different states:
To do:
add unit testsmoved to Filings UI: add unit tests for Todo List, Pending List and Filing History List #22399The text was updated successfully, but these errors were encountered: