Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 23520 - Dashboard Updates for Continuation States #697

Merged

Conversation

ArwenQin
Copy link
Collaborator

@ArwenQin ArwenQin commented Oct 16, 2024

Issue #: /bcgov/entity#23520

Description of changes:

  • Updated the Filing Dashboard to handle different Continuation Statuses, per new UI Design

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
@ArwenQin ArwenQin self-assigned this Oct 16, 2024
src/App.vue Outdated Show resolved Hide resolved
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
package-lock.json Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
@bcgov bcgov deleted a comment from bcregistry-sre Oct 17, 2024
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
@bcgov bcgov deleted a comment from bcregistry-sre Oct 18, 2024
@severinbeauvais
Copy link
Collaborator

Handled for REJECTED status: Paid: https://business-filings-dev--pr-697-l4j2px9g.web.app/TB2Xip34mj
Not Paid: https://business-filings-dev--pr-697-l4j2px9g.web.app/TtqKY2AXxM

The first scenario is invalid (left over from initial flow) and does not need to be handled specially. Please remove any special code for the first scenario.

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Oct 18, 2024

Please reduce the whitespace between CHANGE REQUESTED and Name Request APPROVED. Try 8px (mt-2). Thanks, done.

image

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Oct 18, 2024

A change you made (related to the divider maybe) introduced too much whitespace between the title/subtitle and divider in this scenario where there is no body. Can you fix please? This is a pre-existing issue and can be fixed in another ticket.

image
https://business-filings-dev--pr-697-l4j2px9g.web.app/BC0814580?accountid=3040

src/App.vue Outdated Show resolved Hide resolved
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks really good. Just a bit more cleanup.

@ArwenQin
Copy link
Collaborator Author

mt-2

This seems irrelevant to current changes. It shows the same space in the dev: https://dev.business.bcregistry.gov.bc.ca/BC0814580

Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
@severinbeauvais
Copy link
Collaborator

mt-2

This seems irrelevant to current changes. It shows the same space in the dev: https://dev.business.bcregistry.gov.bc.ca/BC0814580

Yes, you're right. OK, don't worry about this.

Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
@ArwenQin
Copy link
Collaborator Author

/gcbrun

@bcgov bcgov deleted a comment from bcregistry-sre Oct 18, 2024
@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-filings-dev--pr-697-l4j2px9g.web.app

Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
@ArwenQin
Copy link
Collaborator Author

/gcbrun

Copy link

sonarcloud bot commented Oct 18, 2024

Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Lots of little things but it looks very nice 👍

Let Jacqueline know that any further UI updates should be in a new ticket. (Exception: if something is broken by this PR then keep working on it.)

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-filings-dev--pr-697-l4j2px9g.web.app

@ArwenQin ArwenQin merged commit 5cc4b75 into bcgov:main Oct 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants