-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 23520 - Dashboard Updates for Continuation States #697
Fix 23520 - Dashboard Updates for Continuation States #697
Conversation
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
src/components/Dashboard/FilingHistoryList/subtitles/SubtitleFutureEffectivePaid.vue
Show resolved
Hide resolved
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
The first scenario is invalid (left over from initial flow) and does not need to be handled specially. Please remove any special code for the first scenario. |
|
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
src/components/Dashboard/FilingHistoryList/subtitles/SubtitleRejected.vue
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks really good. Just a bit more cleanup.
This seems irrelevant to current changes. It shows the same space in the dev: https://dev.business.bcregistry.gov.bc.ca/BC0814580 |
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Yes, you're right. OK, don't worry about this. |
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
/gcbrun |
Temporary Url for review: https://business-filings-dev--pr-697-l4j2px9g.web.app |
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
/gcbrun |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Lots of little things but it looks very nice 👍
Let Jacqueline know that any further UI updates should be in a new ticket. (Exception: if something is broken by this PR then keep working on it.)
Temporary Url for review: https://business-filings-dev--pr-697-l4j2px9g.web.app |
Issue #: /bcgov/entity#23520
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).