Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 23520 - Dashboard Updates for Continuation States #697

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
7bcb29c
handle APPROVED status
ArwenQin Oct 16, 2024
3a85066
change NR to Name Request, per new design
ArwenQin Oct 16, 2024
1dfe53e
add a divider line
ArwenQin Oct 16, 2024
e7cb5de
update change requested status wording
ArwenQin Oct 16, 2024
86bfbad
add contact info for awaiting review
ArwenQin Oct 16, 2024
f9e846d
add NR Info for awaiting review
ArwenQin Oct 16, 2024
ac30815
update continuation authorization filing name
ArwenQin Oct 16, 2024
b48c413
FE subtitle updates
ArwenQin Oct 16, 2024
79ecead
update awaiting review language
ArwenQin Oct 16, 2024
5a591f6
update package version
ArwenQin Oct 16, 2024
4399712
update unit tests
ArwenQin Oct 16, 2024
990c947
update package enum
ArwenQin Oct 17, 2024
3679a36
update package enum 2
ArwenQin Oct 17, 2024
67ded4d
re-structure methods
ArwenQin Oct 17, 2024
f424b7b
adjust change_requested NR display
ArwenQin Oct 17, 2024
aa72a59
adjust change_requested NR display 2
ArwenQin Oct 17, 2024
a67ab1c
re-structure methods 2
ArwenQin Oct 17, 2024
ea15a99
handle NR expired situation
ArwenQin Oct 17, 2024
a50030c
load NR for Pending List
ArwenQin Oct 17, 2024
bfb638f
update unit tests
ArwenQin Oct 17, 2024
3bd5b6f
fix header status type
ArwenQin Oct 17, 2024
d5b0b5d
updates for filing label - continuation application and authorization
ArwenQin Oct 17, 2024
c28154a
add unit tests for filing names
ArwenQin Oct 17, 2024
7fb25d6
remove FE section for pending Continuation
ArwenQin Oct 17, 2024
e2e1bfd
add a space for subtitle
ArwenQin Oct 17, 2024
777c4dc
move continuation subtitles together in one place
ArwenQin Oct 17, 2024
1c1ccb2
update unit tests, no FE pending continuation now
ArwenQin Oct 17, 2024
0564741
remove FE pending continuation not needed
ArwenQin Oct 17, 2024
20dce67
adjust styles
ArwenQin Oct 18, 2024
f5130ee
adjust subtitle and draftTitle
ArwenQin Oct 18, 2024
003a65e
handle rejected continuation
ArwenQin Oct 18, 2024
74267e5
update FE continuation per new design
ArwenQin Oct 18, 2024
3b732c0
update FE continuation per new design 2
ArwenQin Oct 18, 2024
b099ea0
update unit tests
ArwenQin Oct 18, 2024
c4d41d1
no need to handle rejected paid
ArwenQin Oct 18, 2024
4cf2526
adjust space
ArwenQin Oct 18, 2024
b380669
update comments in todo list
ArwenQin Oct 18, 2024
433ee52
remove unused getter
ArwenQin Oct 18, 2024
cd6de0a
remove unused condition
ArwenQin Oct 18, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "business-filings-ui",
"version": "7.3.26",
"version": "7.3.27",
"private": true,
"appName": "Filings UI",
"sbcName": "SBC Common Components",
Expand All @@ -21,7 +21,7 @@
"@bcrs-shared-components/court-order-poa": "2.1.4",
"@bcrs-shared-components/date-picker": "1.2.39",
"@bcrs-shared-components/document-delivery": "1.2.1",
"@bcrs-shared-components/enums": "1.1.11",
"@bcrs-shared-components/enums": "1.1.12",
"@bcrs-shared-components/expandable-help": "1.0.1",
"@bcrs-shared-components/folio-number-input": "1.1.18",
"@bcrs-shared-components/interfaces": "1.1.13",
Expand Down
15 changes: 9 additions & 6 deletions src/App.vue
Original file line number Diff line number Diff line change
Expand Up @@ -472,9 +472,9 @@ export default class App extends Mixins(
const response = await LegalServices.fetchBootstrapFiling(this.tempRegNumber)
this.storeBootstrapItem(response)

// if it is a todo (not a filing), and it has a NR, load it
// (this is to display the NR details in the Todo List)
if (this.isBootstrapTodo && this.localNrNumber) {
// if it is a todo or a pending filing, and it has a NR, load it
// (this is to display the NR details in the Todo List/Pending List)
if ((this.isBootstrapTodo || this.isBootstrapPending) && this.localNrNumber) {
const nr = await LegalServices.fetchNameRequest(this.localNrNumber)
this.storeNrData(nr, response)
}
Expand Down Expand Up @@ -666,10 +666,11 @@ export default class App extends Mixins(
// NB: these were already validated in storeBootstrapItem()
const header = filing.header
const data = filing[header.name]
const status = header.status

const description = GetCorpFullDescription(data.nameRequest.legalType)
const dba = this.isEntitySoleProp ? ' / Doing Business As (DBA) ' : ' '
const filingName = EnumUtilities.filingTypeToName(header.name, null, data.type)
const filingName = EnumUtilities.filingTypeToName(header.name, null, data.type, status)

// save display name for later
filing.displayName = EnumUtilities.isTypeAmalgamationApplication(header)
Expand All @@ -691,6 +692,7 @@ export default class App extends Mixins(
// NB: these were already validated in storeBootstrapItem()
const header = filing.header
const data = filing[header.name]
const status = header.status

// set addresses
this.storeAddresses({ data: data.offices || [] })
Expand All @@ -699,7 +701,7 @@ export default class App extends Mixins(
this.storeParties({ data: { parties: data.parties || [] } })

const description = GetCorpFullDescription(data.nameRequest.legalType)
const filingName = EnumUtilities.filingTypeToName(header.name, null, data.type)
const filingName = EnumUtilities.filingTypeToName(header.name, null, data.type, status)

// save display name for later
filing.displayName = `${description} ${filingName}`
Expand All @@ -714,6 +716,7 @@ export default class App extends Mixins(
// NB: these were already validated in storeBootstrapItem()
const header = filing.header
const data = filing[header.name]
const status = header.status

// set addresses
this.storeAddresses({ data: data.offices || [] })
Expand All @@ -722,7 +725,7 @@ export default class App extends Mixins(
this.storeParties({ data: { parties: data.parties || [] } })

const description = GetCorpFullDescription(data.nameRequest.legalType)
const filingName = EnumUtilities.filingTypeToName(header.name, null, data.type)
const filingName = EnumUtilities.filingTypeToName(header.name, null, data.type, status)
const displayName = EnumUtilities.isTypeAmalgamationApplication(header)
? filingName
: `${description} ${filingName}`
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ export default class BodyFutureEffective extends Vue {
}
if (EnumUtilities.isTypeContinuationIn(this.filing)) {
return {
subtitle: 'Future Effective Incorporation Date',
filingLabel: 'incorporation',
subtitle: 'Future Effective Continuation Date',
filingLabel: 'filing',
filingTitle: FilingNames.CONTINUATION_IN_APPLICATION
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@ export default class BodyFutureEffectivePending extends Vue {
}
if (EnumUtilities.isTypeContinuationIn(this.filing)) {
return {
subtitle: 'Incorporation Pending',
filingLabel: 'incorporation'
subtitle: 'Continuation Pending',
filingLabel: 'filing'
}
}
return {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<template>
<div class="subtitle-future-effective-paid">
<span v-if="isTypeIncorporationApplication">FUTURE EFFECTIVE INCORPORATION</span>
<span v-else-if="isTypeContinuationApplication">FUTURE EFFECTIVE</span>
severinbeauvais marked this conversation as resolved.
Show resolved Hide resolved
<span v-else-if="isTypeAlteration">FUTURE EFFECTIVE ALTERATION</span>
<span v-else-if="isTypeDissolutionVoluntary">FUTURE EFFECTIVE DISSOLUTION</span>
<span v-else>FUTURE EFFECTIVE FILING</span>
Expand Down Expand Up @@ -45,6 +46,11 @@ export default class SubtitleFutureEffectivePaid extends Vue {
return EnumUtilities.isTypeIncorporationApplication(this.filing)
}

/** Whether this is an continuation application. */
get isTypeContinuationApplication (): boolean {
return EnumUtilities.isTypeContinuationIn(this.filing)
}

/** Whether this is an alteration. */
get isTypeAlteration (): boolean {
return EnumUtilities.isTypeAlteration(this.filing)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,11 @@
<div class="subtitle-rejected">
<span class="orange--text text--darken-2">REJECTED</span>
<span class="vert-pipe" />
<span>PAID (filed by {{ filing.submitter }} on <DateTooltip :date="submittedDate" />)</span>
<!-- Handle Continuation Filings -->
<span v-if="EnumUtilities.isTypeContinuationIn(filing)">
Submitted by {{ filing.submitter }} on <DateTooltip :date="submittedDate" />
</span>
<span v-else>PAID (filed by {{ filing.submitter }} on <DateTooltip :date="submittedDate" />)</span>
severinbeauvais marked this conversation as resolved.
Show resolved Hide resolved

<!-- <v-btn
class="details-btn"
Expand All @@ -24,6 +28,7 @@ import { Action } from 'pinia-class'
import { ApiFilingIF } from '@/interfaces'
import { useFilingHistoryListStore } from '@/stores'
import { DateTooltip } from '@/components/common'
import { EnumUtilities } from '@/services/'
import FiledLabel from '../FiledLabel.vue'

@Component({
Expand All @@ -38,6 +43,8 @@ export default class SubtitleRejected extends Vue {

@Action(useFilingHistoryListStore) toggleFilingHistoryItem!: (x: number) => Promise<void>

readonly EnumUtilities = EnumUtilities

get submittedDate (): Date {
return new Date(this.filing.submittedDate)
}
Expand Down
14 changes: 11 additions & 3 deletions src/components/Dashboard/PendingList/PendingTemplate.vue
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,10 @@
<div class="item-header-subtitle">
<span>PENDING STAFF REVIEW</span>
<span class="vert-pipe" />
<span>Submitted on <DateTooltip :date="submittedDate" />)</span>
<span>Submitted by {{ item.header.submitter }} on <DateTooltip :date="submittedDate" />)</span>
<p v-if="getNameRequest">
Name Request APPROVED - {{ expiresText(getNameRequest) }}
</p>
</div>
</slot>
</div>
Expand Down Expand Up @@ -57,16 +60,21 @@
</template>

<script lang="ts">
import { Component, Prop, Vue } from 'vue-property-decorator'
import { Component, Prop, Mixins } from 'vue-property-decorator'
import { DateTooltip } from '@/components/common'
import { DateMixin } from '@/mixins'
import { Getter } from 'pinia-class'
import { useRootStore } from '@/stores'

@Component({
components: { DateTooltip }
})
export default class PendingTemplate extends Vue {
export default class PendingTemplate extends Mixins(DateMixin) {
@Prop({ required: true }) readonly item!: any
@Prop({ required: true }) readonly index!: number

@Getter(useRootStore) getNameRequest!: any

get submitter (): Date {
return this.item.header.submitter
}
Expand Down
52 changes: 5 additions & 47 deletions src/components/Dashboard/PendingList/filings/ContinuationIn.vue
Original file line number Diff line number Diff line change
Expand Up @@ -7,79 +7,37 @@
>
<template #body>
<div class="body-2">
<h4 v-if="isFutureEffectivePast || isFutureEffective">
severinbeauvais marked this conversation as resolved.
Show resolved Hide resolved
Future Effective Incorporation
</h4>

<v-divider class="mt-1 mb-4" />
<p
class="mb-0"
:class="{ 'mt-4': isFutureEffectivePast || isFutureEffective }"
>
BC Registries will review your
Continuation Authorization documents and contact you with the results within 2 business days.
</p>

<p
v-if="isFutureEffectivePast"
class="mt-4 mb-0"
>
If approved, the incorporation date and time for {{ getLegalName || 'this company' }} will be
recorded as <strong>{{ effectiveDateTime || '[unknown]' }}</strong>.
</p>

<p
v-if="isFutureEffective"
class="mt-4 mb-0"
>
If approved, the incorporation date and time for {{ getLegalName || 'this company' }} will be
<strong>{{ effectiveDateTime || '[unknown]' }}</strong>.
BC Registries will review your documents and contact you with the results within 5 business days.
</p>
<ContactInfo class="mt-4 contact-info-warning" />
</div>
</template>
</PendingTemplate>
</template>

<script lang="ts">
import { Component, Prop, Vue } from 'vue-property-decorator'
import { Getter } from 'pinia-class'
import { useBusinessStore } from '@/stores'
import { DateUtilities } from '@/services'
import { ContactInfo } from '@/components/common'
import PendingTemplate from '../PendingTemplate.vue'
import { GetCorpFullDescription } from '@bcrs-shared-components/corp-type-module'

@Component({
components: {
ContactInfo,
PendingTemplate
}
})
export default class ContinuationIn extends Vue {
@Prop({ required: true }) readonly item!: any
@Prop({ required: true }) readonly index!: number

@Getter(useBusinessStore) getLegalName!: string

get entityType (): string {
severinbeauvais marked this conversation as resolved.
Show resolved Hide resolved
return GetCorpFullDescription(this.item.business.legalType)
}

get isFutureEffectivePast (): boolean {
return (
this.item.header.isFutureEffective &&
DateUtilities.isDatePast(this.item.header.effectiveDate)
)
}

get isFutureEffective (): boolean {
return (
this.item.header.isFutureEffective &&
DateUtilities.isDateFuture(this.item.header.effectiveDate)
)
}

get effectiveDateTime (): string {
const effectiveDate = this.item.header.effectiveDate
return effectiveDate ? DateUtilities.dateToPacificDateTime(new Date(effectiveDate)) : '[unknown]'
}
}
</script>

Expand Down
Loading
Loading