Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

14672 Update approval type to be required field in restoration schema #131

Merged

Conversation

argush3
Copy link
Collaborator

@argush3 argush3 commented Mar 30, 2023

Issue #: /bcgov/entity#14672

Description of changes:

  • Update approvalType in restoration schema a required field.
  • Update tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-schemas license (Apache 2.0).

@argush3 argush3 force-pushed the 14672_restoration_schema_approval_type_update branch from f12ef7b to 9695382 Compare March 30, 2023 19:40
Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@ketaki-deodhar ketaki-deodhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@argush3 argush3 merged commit 1f068c2 into bcgov:main Mar 31, 2023
@argush3 argush3 deleted the 14672_restoration_schema_approval_type_update branch March 31, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants